Refactoring: Extract interface for VC in release scripts.

tools/push-to-trunk/auto_tag.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import sys
 
 from common_includes import *
 
 
 class Preparation(Step):
   MESSAGE = "Preparation."
 
   def RunStep(self):
     self.CommonPrepare()
     self.PrepareBranch()
     self.GitCheckout("master")
-    self.GitSVNRebase()
+    self.vc.Pull()
 
 
 class GetTags(Step):
   MESSAGE = "Get all V8 tags."
 
   def RunStep(self):
     self.GitCreateBranch(self._config["BRANCHNAME"])
-
-    # Get remote tags.
-    tags = filter(lambda s: re.match(r"^svn/tags/[\d+\.]+$", s),
-                  self.GitRemotes())
-
-    # Remove 'svn/tags/' prefix.
-    self["tags"] = map(lambda s: s[9:], tags)
+    self["tags"] = self.vc.GetTags()
 
 
 class GetOldestUntaggedVersion(Step):
   MESSAGE = "Check if there's a version on bleeding edge without a tag."
 
   def RunStep(self):
     tags = set(self["tags"])
     self["candidate"] = None
     self["candidate_version"] = None
     self["next"] = None
@@ skipping 63 matching lines @@
     (exclusive).
     """
     for lkgr in self["lkgrs"]:
       # LKGRs are reverse sorted.
       if int(min_rev) <= int(lkgr) and int(lkgr) < int(max_rev):
         return lkgr
     return None
 
   def RunStep(self):
     # Get the lkgr after the tag candidate and before the next tag candidate.
-    candidate_svn = self.GitSVNFindSVNRev(self["candidate"])
+    candidate_svn = self.vc.GitSvn(self["candidate"])
     if self["next"]:
-      next_svn = self.GitSVNFindSVNRev(self["next"])
+      next_svn = self.vc.GitSvn(self["next"])
     else:
       # Don't include the version change commit itself if there is no upper
       # limit yet.
       candidate_svn =  str(int(candidate_svn) + 1)
       next_svn = sys.maxint
     lkgr_svn = self.LastLKGR(candidate_svn, next_svn)
 
     if not lkgr_svn:
       print "There is no lkgr since the candidate version yet."
       self.CommonCleanup()
       return True
 
     # Let's check if the lkgr is at least three hours old.
-    self["lkgr"] = self.GitSVNFindGitHash(lkgr_svn)
+    self["lkgr"] = self.vc.SvnGit(lkgr_svn)
     if not self["lkgr"]:
       print "Couldn't find git hash for lkgr %s" % lkgr_svn
       self.CommonCleanup()
       return True
 
     lkgr_utc_time = int(self.GitLog(n=1, format="%at", git_hash=self["lkgr"]))
     current_utc_time = self._side_effect_handler.GetUTCStamp()
 
     if current_utc_time < lkgr_utc_time + 10800:
       print "Candidate lkgr %s is too recent for tagging." % lkgr_svn
       self.CommonCleanup()
       return True
 
     print "Tagging revision %s with %s" % (lkgr_svn, self["candidate_version"])
 
 
 class MakeTag(Step):
   MESSAGE = "Tag the version."
 
   def RunStep(self):
     if not self._options.dry_run:
       self.GitReset(self["lkgr"])
-      self.GitSVNTag(self["candidate_version"])
+      self.vc.Tag(self["candidate_version"])
 
 
 class CleanUp(Step):
   MESSAGE = "Clean up."
 
   def RunStep(self):
     self.CommonCleanup()
 
 
 class AutoTag(ScriptsBase):
@@ skipping 23 matching lines @@
       GetOldestUntaggedVersion,
       GetLKGRs,
       CalculateTagRevision,
       MakeTag,
       CleanUp,
     ]
 
 
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(AutoTag().Run())