Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 607233002: Nukes NativeViewportClient::OnCreated (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Nukes NativeViewportClient::OnCreated And replaces with a callback. Also renames SetBounds to SetSize. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/328fbe55a2d5b03d63670bc033e4b2f7274a3cff Cr-Commit-Position: refs/heads/master@{#297187}

Patch Set 1 #

Patch Set 2 : one more #

Patch Set 3 : size #

Patch Set 4 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -79 lines) Patch
M mojo/examples/compositor_app/compositor_app.cc View 3 chunks +19 lines, -12 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 6 chunks +23 lines, -15 lines 0 comments Download
M mojo/examples/sample_app/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 2 4 chunks +21 lines, -16 lines 0 comments Download
M mojo/examples/surfaces_app/surfaces_app.cc View 6 chunks +10 lines, -4 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_impl.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +6 lines, -4 lines 0 comments Download
M mojo/services/view_manager/display_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/display_manager.cc View 4 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
sky
6 years, 2 months ago (2014-09-26 22:24:50 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-09-26 23:11:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607233002/40001
6 years, 2 months ago (2014-09-26 23:13:26 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/19603)
6 years, 2 months ago (2014-09-26 23:25:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607233002/40001
6 years, 2 months ago (2014-09-27 03:18:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/19652)
6 years, 2 months ago (2014-09-27 03:33:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607233002/40001
6 years, 2 months ago (2014-09-29 14:40:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/19843)
6 years, 2 months ago (2014-09-29 14:51:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607233002/60001
6 years, 2 months ago (2014-09-29 15:39:25 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 736a843120f98d9b46eff0007bd9e43eb2935cb3
6 years, 2 months ago (2014-09-29 16:28:55 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 16:29:34 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/328fbe55a2d5b03d63670bc033e4b2f7274a3cff
Cr-Commit-Position: refs/heads/master@{#297187}

Powered by Google App Engine
This is Rietveld 408576698