Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: mojo/services/public/interfaces/native_viewport/native_viewport.mojom

Issue 607233002: Nukes NativeViewportClient::OnCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/native_viewport/native_viewport_impl.cc ('k') | mojo/services/view_manager/display_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/interfaces/native_viewport/native_viewport.mojom
diff --git a/mojo/services/public/interfaces/native_viewport/native_viewport.mojom b/mojo/services/public/interfaces/native_viewport/native_viewport.mojom
index 61afb1aa7eafa2273fabfd5a7101a7cd9b67958c..0a685328f72020ecd583c5e3a0cb5d387dd84e27 100644
--- a/mojo/services/public/interfaces/native_viewport/native_viewport.mojom
+++ b/mojo/services/public/interfaces/native_viewport/native_viewport.mojom
@@ -11,17 +11,19 @@ module mojo {
[Client=NativeViewportClient]
interface NativeViewport {
- Create(Size size);
+ // TODO(sky): having a create function is awkward. Should there be a factory
+ // to create the NativeViewport that takes the size?
+ // TODO(sky): callback should take size too.
+ Create(Size size) => (uint64 native_viewport_id);
Show();
Hide();
Close();
- SetBounds(Size size);
+ SetSize(Size size);
SubmittedFrame(SurfaceId surface_id);
};
interface NativeViewportClient {
- OnCreated(uint64 native_viewport_id);
- OnBoundsChanged(Size size);
+ OnSizeChanged(Size size);
OnDestroyed();
OnEvent(Event event) => ();
};
« no previous file with comments | « mojo/services/native_viewport/native_viewport_impl.cc ('k') | mojo/services/view_manager/display_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698