Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 607113002: Revert of DevTools: Avoid build errors when dynamic module and application names clash (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
Reviewers:
dgozman, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: Avoid build errors when dynamic module and application names clash (patchset #2 id:20001 of https://codereview.chromium.org/607893002/) Reason for revert: This patch makes the "build_applications" target always dirty. Original issue's description: > DevTools: Avoid build errors when dynamic module and application names clash > > This is a provisional fix that should let developers name > dynamically loaded modules the same as existing applications. > > Drive-by: > - Clean up devtools.gypi > - Stop generating obsolete code when concatenating workers > > R=dgozman, pfeldman, yurys > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182769 TBR=dgozman@chromium.org,pfeldman@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -68 lines) Patch
M Source/devtools/BUILD.gn View 3 chunks +24 lines, -26 lines 0 comments Download
M Source/devtools/devtools.gyp View 19 chunks +36 lines, -36 lines 0 comments Download
M Source/devtools/devtools.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Runtime.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/scripts/concatenate_application_code.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
apavlov
Created Revert of DevTools: Avoid build errors when dynamic module and application names clash
6 years, 2 months ago (2014-09-26 16:38:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607113002/1
6 years, 2 months ago (2014-09-26 16:39:17 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 16:39:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182775

Powered by Google App Engine
This is Rietveld 408576698