Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 607063003: cc: Allow fully solid layers to contribute their pixels to quad_data.visible_content_area (Closed)

Created:
6 years, 2 months ago by hendrikw
Modified:
6 years, 2 months ago
Reviewers:
danakj, ernstm
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Allow fully solid layers to contribute pixels for telemetry The theory is that some of the tests that check mean_pixels_approximated could become worse after my change because PLI's drawn as solid color were not adding its drawn pixels into the calculation. I can't replicate the test, possibly due to lack of throttling on my phone, so the plan is to commit this change and see if the tests go back to normal. Even if it doesn't improve the test, the change is correct and should be committed regardless. BUG=416446 Committed: https://crrev.com/3c37dba2da292e0342d39731d6fe558340521bb5 Cr-Commit-Position: refs/heads/master@{#297087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/solid_color_layer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/solid_color_layer_impl.cc View 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hendrikw
PTAL
6 years, 2 months ago (2014-09-26 18:16:48 UTC) #2
ernstm
On 2014/09/26 18:16:48, Hendrik wrote: > PTAL LGTM
6 years, 2 months ago (2014-09-26 18:41:02 UTC) #3
danakj
LGTM
6 years, 2 months ago (2014-09-26 22:06:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607063003/1
6 years, 2 months ago (2014-09-26 22:07:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7b800b173d46514841b6476956ea83b7fef4cc97
6 years, 2 months ago (2014-09-27 00:53:05 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 00:54:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c37dba2da292e0342d39731d6fe558340521bb5
Cr-Commit-Position: refs/heads/master@{#297087}

Powered by Google App Engine
This is Rietveld 408576698