Protect against setting meta info on unmodifiable nodes.

Protect against setting meta info on unmodifiable nodes.

BUG=418226
Committed: https://crrev.com/f6506c317e4431992a48d010971801ff3a5c3200
Cr-Commit-Position: refs/heads/master@{#297068}

[Rune Fevang, 2014-09-26 00:33:33]

rfevang@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Jeffrey Yasskin, 2014-09-26 01:19:19]

Is there a bug or anything giving more context about this?

https://codereview.chromium.org/606923002/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js
(right):

https://codereview.chromium.org/606923002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js:347:
bookmarkManager.setMetaInfo(unmodifiableFolder.id, 'meta', 'foo', fail(
I saw two checks in the real code, for !CanBeModified() and for
is_permanent_node(). Can you write tests for both of them?

[Rune Fevang, 2014-09-26 20:44:06]

Thanks, added bug and extra test.

https://codereview.chromium.org/606923002/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js
(right):

https://codereview.chromium.org/606923002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js:347:
bookmarkManager.setMetaInfo(unmodifiableFolder.id, 'meta', 'foo', fail(
On 2014/09/26 01:19:19, Jeffrey Yasskin wrote:
> I saw two checks in the real code, for !CanBeModified() and for
> is_permanent_node(). Can you write tests for both of them?

Done.

[Jeffrey Yasskin, 2014-09-26 20:49:20]

lgtm

[Rune Fevang, 2014-09-26 21:37:12]

The CQ bit was checked by rfevang@chromium.org

[commit-bot: I haz the power, 2014-09-26 21:40:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606923002/20001

[commit-bot: I haz the power, 2014-09-26 23:28:37]

Committed patchset #2 (id:20001) as 0a86094081bd6b70e5126c1a113d714b46bf9547

[commit-bot: I haz the power, 2014-09-26 23:29:15]

Patchset 2 (id:??) landed as
https://crrev.com/f6506c317e4431992a48d010971801ff3a5c3200
Cr-Commit-Position: refs/heads/master@{#297068}