Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5111)

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 606923002: Protect against setting meta info on unmodifiable nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Extra test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
index 82ca22dc080752a1cb0f377f39d9563323db3839..fea374a576afe2ff37ab3df1940bd58b7363800f 100644
--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
@@ -721,7 +721,15 @@ bool BookmarkManagerPrivateSetMetaInfoFunction::RunOnReady() {
if (!node)
return false;
+ if (!CanBeModified(node))
+ return false;
+
BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
+ if (model->is_permanent_node(node)) {
+ error_ = bookmark_keys::kModifySpecialError;
+ return false;
+ }
+
model->SetNodeMetaInfo(node, params->key, params->value);
return true;
}
@@ -735,7 +743,15 @@ bool BookmarkManagerPrivateUpdateMetaInfoFunction::RunOnReady() {
if (!node)
return false;
+ if (!CanBeModified(node))
+ return false;
+
BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
+ if (model->is_permanent_node(node)) {
+ error_ = bookmark_keys::kModifySpecialError;
+ return false;
+ }
+
BookmarkNode::MetaInfoMap new_meta_info(
params->meta_info_changes.additional_properties);
if (node->GetMetaInfoMap()) {
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698