Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 606843002: Make a context struct for ServiceWorkerCache::Put callbacks. (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make a context struct for ServiceWorkerCache::Put callbacks. The Put callback functions took an absurd number of paramters. This CL simplifies by putting them in a context struct. This is needed by a downstream CL that needs to add another member to the struct. Upstream of: https://codereview.chromium.org/608593003 BUG=392621 Committed: https://crrev.com/b022bc195c2fc9b587eab2bd92cc31fb4ec771cb Cr-Commit-Position: refs/heads/master@{#297164}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added a clarifying comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -81 lines) Patch
M content/browser/service_worker/service_worker_cache.cc View 1 14 chunks +92 lines, -81 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jkarlin
michaeln@chromium.org: Please review changes in all horo@chromium.org: Please review changes in all Thanks!
6 years, 2 months ago (2014-09-25 19:17:40 UTC) #2
horo
https://codereview.chromium.org/606843002/diff/1/content/browser/service_worker/service_worker_cache.cc File content/browser/service_worker/service_worker_cache.cc (right): https://codereview.chromium.org/606843002/diff/1/content/browser/service_worker/service_worker_cache.cc#newcode189 content/browser/service_worker/service_worker_cache.cc:189: disk_cache::Entry* cache_entry; Why don't you use ScopedEntryPtr?
6 years, 2 months ago (2014-09-26 02:15:02 UTC) #3
jkarlin
https://codereview.chromium.org/606843002/diff/1/content/browser/service_worker/service_worker_cache.cc File content/browser/service_worker/service_worker_cache.cc (right): https://codereview.chromium.org/606843002/diff/1/content/browser/service_worker/service_worker_cache.cc#newcode189 content/browser/service_worker/service_worker_cache.cc:189: disk_cache::Entry* cache_entry; On 2014/09/26 02:15:02, horo wrote: > Why ...
6 years, 2 months ago (2014-09-26 11:15:02 UTC) #4
horo
lgtm https://codereview.chromium.org/606843002/diff/1/content/browser/service_worker/service_worker_cache.cc File content/browser/service_worker/service_worker_cache.cc (right): https://codereview.chromium.org/606843002/diff/1/content/browser/service_worker/service_worker_cache.cc#newcode189 content/browser/service_worker/service_worker_cache.cc:189: disk_cache::Entry* cache_entry; On 2014/09/26 11:15:02, jkarlin wrote: > ...
6 years, 2 months ago (2014-09-29 03:13:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606843002/20001
6 years, 2 months ago (2014-09-29 12:53:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3d8ba41cd4c816b77fcc70a3d6ec2c0809ce2965
6 years, 2 months ago (2014-09-29 13:22:01 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 13:23:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b022bc195c2fc9b587eab2bd92cc31fb4ec771cb
Cr-Commit-Position: refs/heads/master@{#297164}

Powered by Google App Engine
This is Rietveld 408576698