Chromium Code Reviews Chromium Code Reviews
Issue
60683003:
A number of paint optimizations to improve overall paint times. (Closed)
DescriptionA number of paint optimizations to improve overall paint times.
Here's the run down:
. Removes unnecessary SchedulePaint() in
DesktopRootWindowHostWin::SetOpacity. SchedulePaint isn't necessary
here as opacity is handled by the layer.
. Textfield::SetHorizontal/VerticalMargins should only invoke
PreferredSizeChanged() if margins actually changed. Otherwise we
invalidated all the way up the view hierarchy. This means the next
call to Layout() at the root is going to layout and repaint
everything.
. Adds ImageView::SetImageByResourceID. Adding this allows us to do
nothing if the image has changed.
. StatusBubbleView was unnecessarily calling SchedulePaint in some
situtations. In particular it should only SchedulePaint() if the
text actually changes.
. Changes a number of places in LocationBar to only SchedulePaint() if
something actually changed. These methods can all be invoked rather
frequently.
BUG=313494
TEST=none
R=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234692
Patch Set 1 #Patch Set 2 : remove unnecessary includes #Patch Set 3 : remove SetImageByResourceID and use BackedBySameObjectAs #
Messages
Total messages: 8 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
