Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4461)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 60683003: A number of paint optimizations to improve overall paint times. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove SetImageByResourceID and use BackedBySameObjectAs Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index 84fe452f3b296fa5086cdebd1ea9e24347e493bb..1493b73db9679797f3920405ef2885f7ecfec3f1 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -378,25 +378,28 @@ class LocationBarView : public LocationBar,
}
// Updates the visibility state of the Content Blocked icons to reflect what
- // is actually blocked on the current page.
- void RefreshContentSettingViews();
+ // is actually blocked on the current page. Returns true if the visibility
+ // of at least one of the views in |content_setting_views_| changed.
+ bool RefreshContentSettingViews();
// Deletes all page action views that we have created.
void DeletePageActionViews();
// Updates the views for the Page Actions, to reflect state changes for
- // PageActions.
- void RefreshPageActionViews();
+ // PageActions. Returns true if the visibility of a PageActionWithBadgeView
+ // changed, or PageActionWithBadgeView were created/destroyed.
+ bool RefreshPageActionViews();
// Returns the number of scripts currently running on the page.
size_t ScriptBubbleScriptsRunning();
// Updates the Script Bubble Icon, to reflect the number of content scripts
- // running on the page.
- void RefreshScriptBubble();
+ // running on the page. Returns true if the visibility of the bubble changed.
+ bool RefreshScriptBubble();
- // Updates the view for the zoom icon based on the current tab's zoom.
- void RefreshZoomView();
+ // Updates the view for the zoom icon based on the current tab's zoom. Returns
+ // true if the visibility of the view changed.
+ bool RefreshZoomView();
// Updates the Translate icon based on the current tab's Translate status.
void RefreshTranslateIcon();
@@ -404,7 +407,8 @@ class LocationBarView : public LocationBar,
// Sets the visibility of view to new_vis.
void ToggleVisibility(bool new_vis, views::View* view);
- void RefreshManagePasswordsIconView();
+ // Updates |manage_passwords_icon_view_|. Returns true if visibility changed.
+ bool RefreshManagePasswordsIconView();
// Shows the manage passwords bubble if there is a savable password.
void ShowManagePasswordsBubbleIfNeeded();
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698