Allow file: uris for <file> input types

Allow file: uris for <file> input types
Also changed all the if/else to early returns

BUG=176703
Test:
Installed File Manager from play

 Loaded GMail in html mode (mail.google.com/?ui=html) verified that the Attach file is in fact a <file> tag. Sent myself a mail with an attachment. Verifed that the file was properly sent

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233965

[Miguel Garcia, 2013-11-05 19:44:03]

aurimas as the main reviwer since he upstreamed this
tedchoc for owners approval

[aurimas (slooooooooow), 2013-11-05 20:52:07]

LGTM with a nit.

Also you might want to communicate with qinmin@ to see how this affects
crbug.com/278640

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
File ui/android/java/src/org/chromium/ui/SelectFileDialog.java (right):

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/SelectFileDialog.java:161: if
("file".equals(results.getData().getScheme())) {
Should pull "file" out as a constant.

[Miguel Garcia, 2013-11-06 18:07:51]

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
File ui/android/java/src/org/chromium/ui/SelectFileDialog.java (right):

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/SelectFileDialog.java:161: if
("file".equals(results.getData().getScheme())) {
On 2013/11/05 20:52:07, aurimas wrote:
> Should pull "file" out as a constant.

Really? In this case it just seems an overkill. I was looking if the constant
was officially defined somewhere else but couldn't not find it.

[Miguel Garcia, 2013-11-08 12:55:36]

On 2013/11/06 18:07:51, Miguel Garcia wrote:
>
https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
> File ui/android/java/src/org/chromium/ui/SelectFileDialog.java (right):
> 
>
https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
> ui/android/java/src/org/chromium/ui/SelectFileDialog.java:161: if
> ("file".equals(results.getData().getScheme())) {
> On 2013/11/05 20:52:07, aurimas wrote:
> > Should pull "file" out as a constant.
> 
> Really? In this case it just seems an overkill. I was looking if the constant
> was officially defined somewhere else but couldn't not find it.

Friendly ping on this Ted. It should a straight forward review.

[Ted C, 2013-11-08 17:00:13]

lgtm

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
File ui/android/java/src/org/chromium/ui/SelectFileDialog.java (right):

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/SelectFileDialog.java:161: if
("file".equals(results.getData().getScheme())) {
On 2013/11/06 18:07:51, Miguel Garcia wrote:
> On 2013/11/05 20:52:07, aurimas wrote:
> > Should pull "file" out as a constant.
> 
> Really? In this case it just seems an overkill. I was looking if the constant
> was officially defined somewhere else but couldn't not find it.
> 

I hit this same issue anytime I want to check against http or https, there
doesn't seem to be constants anywhere and almost all usages are inlined.  I
don't necessarily like it, but it's consistent which is often more important.

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/SelectFileDialog.java:189: cursor.close();
this could all fit on one line

[commit-bot: I haz the power, 2013-11-08 17:23:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miguelg@chromium.org/60673003/90001

[commit-bot: I haz the power, 2013-11-08 20:27:26]

Change committed as 233965

[Miguel Garcia, 2013-11-09 07:09:07]

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
File ui/android/java/src/org/chromium/ui/SelectFileDialog.java (right):

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/SelectFileDialog.java:161: if
("file".equals(results.getData().getScheme())) {
Ok, will leave it as is then.

On 2013/11/08 17:00:13, Ted C wrote:
> On 2013/11/06 18:07:51, Miguel Garcia wrote:
> > On 2013/11/05 20:52:07, aurimas wrote:
> > > Should pull "file" out as a constant.
> > 
> > Really? In this case it just seems an overkill. I was looking if the
constant
> > was officially defined somewhere else but couldn't not find it.
> > 
> 
> I hit this same issue anytime I want to check against http or https, there
> doesn't seem to be constants anywhere and almost all usages are inlined.  I
> don't necessarily like it, but it's consistent which is often more important.

https://codereview.chromium.org/60673003/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/SelectFileDialog.java:189: cursor.close();
On 2013/11/08 17:00:13, Ted C wrote:
> this could all fit on one line

Done.