Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 606663002: Remove unused WebRemoteFrameImpl::viewImpl() helper. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, dcheng, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused WebRemoteFrameImpl::viewImpl() helper. Added by r182337; an, as it turned out, unused helper that wasn't removed there. R=haraken,jochen BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/web/WebRemoteFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
Please take a look.
6 years, 2 months ago (2014-09-25 13:35:01 UTC) #2
haraken
LGTM.
6 years, 2 months ago (2014-09-25 13:36:13 UTC) #3
Mike West
Yay! Less code is better code.
6 years, 2 months ago (2014-09-25 13:40:40 UTC) #5
sof
On 2014/09/25 13:40:40, Mike West wrote: > Yay! Less code is better code. jochen@: web/ ...
6 years, 2 months ago (2014-09-25 13:46:38 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-26 19:44:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606663002/1
6 years, 2 months ago (2014-09-27 19:29:11 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 09:34:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182818

Powered by Google App Engine
This is Rietveld 408576698