Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: Source/web/WebRemoteFrameImpl.h

Issue 606663002: Remove unused WebRemoteFrameImpl::viewImpl() helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebRemoteFrameImpl_h 5 #ifndef WebRemoteFrameImpl_h
6 #define WebRemoteFrameImpl_h 6 #define WebRemoteFrameImpl_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "public/web/WebRemoteFrame.h" 9 #include "public/web/WebRemoteFrame.h"
10 #include "public/web/WebRemoteFrameClient.h" 10 #include "public/web/WebRemoteFrameClient.h"
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 185
186 virtual void initializeFromFrame(WebLocalFrame*) const OVERRIDE; 186 virtual void initializeFromFrame(WebLocalFrame*) const OVERRIDE;
187 187
188 virtual void trace(Visitor*); 188 virtual void trace(Visitor*);
189 189
190 private: 190 private:
191 RemoteFrameClient m_frameClient; 191 RemoteFrameClient m_frameClient;
192 RefPtrWillBeMember<RemoteFrame> m_frame; 192 RefPtrWillBeMember<RemoteFrame> m_frame;
193 WebRemoteFrameClient* m_client; 193 WebRemoteFrameClient* m_client;
194 194
195 WebViewImpl* viewImpl() const;
196
197 WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> > m_ownersForChi ldren; 195 WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> > m_ownersForChi ldren;
198 196
199 #if ENABLE(OILPAN) 197 #if ENABLE(OILPAN)
200 // Oilpan: to provide the guarantee of having the frame live until 198 // Oilpan: to provide the guarantee of having the frame live until
201 // close() is called, an instance keep a self-persistent. It is 199 // close() is called, an instance keep a self-persistent. It is
202 // cleared upon calling close(). This avoids having to assume that 200 // cleared upon calling close(). This avoids having to assume that
203 // an embedder's WebFrame references are all discovered via thread 201 // an embedder's WebFrame references are all discovered via thread
204 // state (stack, registers) should an Oilpan GC strike while we're 202 // state (stack, registers) should an Oilpan GC strike while we're
205 // in the process of detaching. 203 // in the process of detaching.
206 GC_PLUGIN_IGNORE("340522") 204 GC_PLUGIN_IGNORE("340522")
207 Persistent<WebRemoteFrameImpl> m_selfKeepAlive; 205 Persistent<WebRemoteFrameImpl> m_selfKeepAlive;
208 #endif 206 #endif
209 }; 207 };
210 208
211 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame()); 209 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame());
212 210
213 } // namespace blink 211 } // namespace blink
214 212
215 #endif // WebRemoteFrameImpl_h 213 #endif // WebRemoteFrameImpl_h
OLDNEW
« no previous file with comments | « no previous file | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698