Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: Source/bindings/tests/results/core/V8SVGTestInterface.cpp

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Win GPU tests (DOMDataView). Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8SVGTestInterface.cpp
diff --git a/Source/bindings/tests/results/core/V8SVGTestInterface.cpp b/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
index 62a65ec8ef3ecbaec426d1903abdf7617cc0f173..cda353fd9a60ada79543f74e277fef8e41e3e51f 100644
--- a/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
+++ b/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
@@ -102,9 +102,10 @@ v8::Handle<v8::Object> V8SVGTestInterface::findInstanceInPrototypeChain(v8::Hand
return V8PerIsolateData::from(isolate)->findInstanceInPrototypeChain(&wrapperTypeInfo, v8Value);
}
+
haraken 2014/10/14 15:11:18 Unnecessary empty line.
Yuki 2014/10/15 09:35:23 Will check when I add a run-binding-test.
SVGTestInterface* V8SVGTestInterface::toImplWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> value)
{
- return hasInstance(value, isolate) ? blink::toScriptWrappableBase(v8::Handle<v8::Object>::Cast(value))->toImpl<SVGTestInterface>() : 0;
+ return hasInstance(value, isolate) ? toImpl(v8::Handle<v8::Object>::Cast(value)) : 0;
haraken 2014/10/14 15:11:18 Isn't this a regression? We want to use ScriptWrap
Yuki 2014/10/15 09:35:23 For v8::ArrayBuffer and its view, it's possible th
}

Powered by Google App Engine
This is Rietveld 408576698