Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Win GPU tests (DOMDataView). Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/code_generator_v8.py
diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py
index 065873d90fd04bc2e58ffdbd3c2af4639b780cd0..a493bd42373a3f495949f02ce4ae4a69dbc7d438 100644
--- a/Source/bindings/scripts/code_generator_v8.py
+++ b/Source/bindings/scripts/code_generator_v8.py
@@ -168,7 +168,10 @@ class CodeGeneratorV8(CodeGeneratorBase):
template_context = interface_context(interface)
# Add the include for interface itself
- template_context['header_includes'].add(interface_info['include_path'])
+ if IdlType(interface_name).is_typed_array_element_type:
bashi 2014/10/14 23:36:24 Can't we move this into interface_context() in v8_
Yuki 2014/10/15 09:35:23 It seems that |interface_info| is not available in
bashi 2014/10/15 10:17:33 Ah, I see. I don't think we have a policy that we
+ template_context['header_includes'].add('core/dom/DOMTypedArray.h')
+ else:
+ template_context['header_includes'].add(interface_info['include_path'])
header_text, cpp_text = render_template(
interface_info, header_template, cpp_template, template_context)
header_path, cpp_path = self.output_paths(interface_name)

Powered by Google App Engine
This is Rietveld 408576698