bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc.

Source/bindings/core/v8/custom/V8FileReaderCustom.cpp

Index: Source/bindings/core/v8/custom/V8FileReaderCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8FileReaderCustom.cpp b/Source/bindings/core/v8/custom/V8FileReaderCustom.cpp
index 5cfb8f7bf6871b5419dde3d22cd8df452b6f49c0..45b43f9221947344a48e9c027f6c56ebc4737f4b 100644
--- a/Source/bindings/core/v8/custom/V8FileReaderCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8FileReaderCustom.cpp
@@ -31,8 +31,8 @@
 #include "config.h"
 #include "bindings/core/v8/V8FileReader.h"
 
+#include "bindings/core/v8/V8ArrayBuffer.h"
 #include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/custom/V8ArrayBufferCustom.h"
 #include "core/dom/ExecutionContext.h"
 
 namespace blink {
@@ -42,7 +42,8 @@ void V8FileReader::resultAttributeGetterCustom(const v8::PropertyCallbackInfo<v8
     v8::Handle<v8::Object> holder = info.Holder();
     FileReader* impl = V8FileReader::toImpl(holder);
     if (impl->readType() == FileReaderLoader::ReadAsArrayBuffer) {
-        v8SetReturnValueFast(info, impl->arrayBufferResult(), impl);
+        RefPtr<DOMArrayBuffer> arrayBuffer = DOMArrayBuffer::create(impl->arrayBufferResult());

[haraken, 2014/10/14 15:11:18]

Help me understand: Where do you want to use DOMArrayBuffer and where do you
want to use ArrayBuffer? For example, you return an ArrayBuffer from
FileReader::arrayBufferResult and create a DOMArrayBuffer here. The programming
rule you have in mind is "use ArrayBuffer in core/ and use DOMArrayBuffer in
bindings/", right?

[Yuki, 2014/10/15 09:35:22]

I made this CL with the least effort, and it's not ideal for me.  I just wanted
to keep this CL as small as possible as the first step.  So there is no wonder
that the DOMArrayXxx/ArrayXxx policy is very unclear.  Sorry for confusion.

Ideally I'd like to use DOMArrayXxx instead of the ArrayXxx which may need
wrappers.  It's almost everywhere.  Having said that, we still need to live with
ArrayBuffer created in platform/ though.

+        v8SetReturnValueFast(info, arrayBuffer.get(), impl);

[haraken, 2014/10/14 15:11:18]

.get() => .release() (There is no behavioral difference but conceptually this
should be .release().)

[Yuki, 2014/10/15 09:35:22]

Done.

         return;
     }
     v8SetReturnValueStringOrNull(info, impl->stringResult(), info.GetIsolate());