CC: Stop TimingFunction inheriting from AnimationCurve.

CC: Stop TimingFunction inheriting from AnimationCurve.

Simplifies code as TimingFunction has no logical reason to inherit from AnimationCurve (apart from sharing a few method names). Make code more clear.

BUG=

Committed: https://crrev.com/470df4f966c86d4e416970415380917b32417b46
Cr-Commit-Position: refs/heads/master@{#296862}

[ikilpatrick, 2014-09-25 05:03:10]

ikilpatrick@chromium.org changed reviewers:
+ samli@chromium.org

[ikilpatrick, 2014-09-25 05:03:18]

https://codereview.chromium.org/606543002/diff/1/cc/animation/timing_function.h
File cc/animation/timing_function.h (right):

https://codereview.chromium.org/606543002/diff/1/cc/animation/timing_function...
cc/animation/timing_function.h:22: virtual scoped_ptr<TimingFunction> Clone()
const = 0;
Is there an idiomatic ordering?
Should the .cc file match the ordering here?

[samli, 2014-09-25 07:46:36]

lgtm

https://codereview.chromium.org/606543002/diff/1/cc/animation/timing_function.h
File cc/animation/timing_function.h (right):

https://codereview.chromium.org/606543002/diff/1/cc/animation/timing_function...
cc/animation/timing_function.h:22: virtual scoped_ptr<TimingFunction> Clone()
const = 0;
On 2014/09/25 05:03:18, ikilpatrick wrote:
> Is there an idiomatic ordering?
Looks fine to me.
> Should the .cc file match the ordering here?
Ideally, but not necessarily?

[ikilpatrick, 2014-09-25 08:49:19]

ikilpatrick@chromium.org changed reviewers:
+ ajuma@chromium.org

[ikilpatrick, 2014-09-25 08:50:27]

https://codereview.chromium.org/606543002/diff/1/cc/animation/timing_function.h
File cc/animation/timing_function.h (right):

https://codereview.chromium.org/606543002/diff/1/cc/animation/timing_function...
cc/animation/timing_function.h:22: virtual scoped_ptr<TimingFunction> Clone()
const = 0;
On 2014/09/25 07:46:36, samli wrote:
> On 2014/09/25 05:03:18, ikilpatrick wrote:
> > Is there an idiomatic ordering?
> Looks fine to me.
> > Should the .cc file match the ordering here?
> Ideally, but not necessarily?

Reordered.

[ajuma, 2014-09-25 14:52:17]

lgtm, but please add a sentence to the description explaining why we're making
this change.

[ikilpatrick, 2014-09-25 23:01:24]

On 2014/09/25 14:52:17, ajuma wrote:
> lgtm, but please add a sentence to the description explaining why we're making
> this change.

Done.

[ikilpatrick, 2014-09-25 23:02:11]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2014-09-25 23:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606543002/20001

[commit-bot: I haz the power, 2014-09-25 23:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 23:18:18]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ikilpatrick, 2014-09-26 00:34:58]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2014-09-26 00:35:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606543002/60001

[commit-bot: I haz the power, 2014-09-26 02:26:43]

Committed patchset #4 (id:60001) as ae27894ae26774981d8e64acb1900b7d8aa0bad9

[commit-bot: I haz the power, 2014-09-26 02:27:24]

Patchset 4 (id:??) landed as
https://crrev.com/470df4f966c86d4e416970415380917b32417b46
Cr-Commit-Position: refs/heads/master@{#296862}