Pass the system url request context getter to the cast service so that it can be used by various sy…

Pass the system url request context getter to the cast service so that it can be used by various system components (e.g. cast receiver).

BUG=None

Committed: https://crrev.com/5b07d9f661d67fbb6e76ad8a0c967a613c31f615
Cr-Commit-Position: refs/heads/master@{#296748}

[lcwu1, 2014-09-25 01:57:21]

lcwu@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2014-09-25 15:50:02]

https://codereview.chromium.org/606513002/diff/1/chromecast/service/cast_serv...
File chromecast/service/cast_service.h (right):

https://codereview.chromium.org/606513002/diff/1/chromecast/service/cast_serv...
chromecast/service/cast_service.h:35: net::URLRequestContextGetter*
request_context_getter);
Hm, is there any case where we actually want to change this parameter? Since
this is called by the content embedder, I would expect it to continue to always
pass in the same argument.

[lcwu1, 2014-09-25 17:07:37]

https://codereview.chromium.org/606513002/diff/1/chromecast/service/cast_serv...
File chromecast/service/cast_service.h (right):

https://codereview.chromium.org/606513002/diff/1/chromecast/service/cast_serv...
chromecast/service/cast_service.h:35: net::URLRequestContextGetter*
request_context_getter);
On 2014/09/25 15:50:02, gunsch wrote:
> Hm, is there any case where we actually want to change this parameter? Since
> this is called by the content embedder, I would expect it to continue to
always
> pass in the same argument.

There are two reasons to pass in an url request context getter to CastService:
(1) CastService doesn't hold a reference to url_request_context_factory and the
request context getter in the browser_context is not (always) what we want, (2)
I want to keep CastService request_context_getter agnostic. That is, it just
uses the request context getter passed in in the constructor without having to
know what this context getter is (and how it is constructed). Currently we would
like to pass in the system context getter to the cast service, but it might
change if later we want to simplify the number of url request context getters
and pass in the main one.

[gunsch, 2014-09-25 17:09:35]

On 2014/09/25 17:07:37, lcwu1 wrote:
>
https://codereview.chromium.org/606513002/diff/1/chromecast/service/cast_serv...
> File chromecast/service/cast_service.h (right):
> 
>
https://codereview.chromium.org/606513002/diff/1/chromecast/service/cast_serv...
> chromecast/service/cast_service.h:35: net::URLRequestContextGetter*
> request_context_getter);
> On 2014/09/25 15:50:02, gunsch wrote:
> > Hm, is there any case where we actually want to change this parameter? Since
> > this is called by the content embedder, I would expect it to continue to
> always
> > pass in the same argument.
> 
> There are two reasons to pass in an url request context getter to CastService:
> (1) CastService doesn't hold a reference to url_request_context_factory and
the
> request context getter in the browser_context is not (always) what we want,
(2)
> I want to keep CastService request_context_getter agnostic. That is, it just
> uses the request context getter passed in in the constructor without having to
> know what this context getter is (and how it is constructed). Currently we
would
> like to pass in the system context getter to the cast service, but it might
> change if later we want to simplify the number of url request context getters
> and pass in the main one.

lgtm

[lcwu1, 2014-09-25 17:46:08]

The CQ bit was checked by lcwu@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:47:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606513002/1

[commit-bot: I haz the power, 2014-09-25 17:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:47:23]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[lcwu1, 2014-09-25 18:08:34]

lcwu@chromium.org changed reviewers:
+ damienv@chromium.org

[damienv1, 2014-09-25 18:18:47]

lgtm

[lcwu1, 2014-09-25 18:23:57]

The CQ bit was checked by lcwu@chromium.org

[commit-bot: I haz the power, 2014-09-25 18:25:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606513002/1

[commit-bot: I haz the power, 2014-09-25 18:39:28]

Committed patchset #1 (id:1) as acc4c7adcc6ef849b996d796e0e684d016c4f1b2

[commit-bot: I haz the power, 2014-09-25 18:41:02]

Patchset 1 (id:??) landed as
https://crrev.com/5b07d9f661d67fbb6e76ad8a0c967a613c31f615
Cr-Commit-Position: refs/heads/master@{#296748}