Pass the system url request context getter to the cast service so that it can be used by various sy…

chromecast/service/cast_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_SERVICE_CAST_SERVICE_H_
 #define CHROMECAST_SERVICE_CAST_SERVICE_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace base {
 class ThreadChecker;
 }
 
 namespace content{
 class BrowserContext;
 }
 
+namespace net {
+class URLRequestContextGetter;
+}
+
 namespace chromecast {
 
 class CastService {
  public:
-  static CastService* Create(content::BrowserContext* browser_context);
+  // Create() takes a separate url request context getter because the request
+  // context getter obtained through the browser context might not be
+  // appropriate for the url requests made by the cast service/reciever.
+  // For example, on Chromecast, it is needed to pass in a system url request
+  // context getter that would set the request context for NSS, which the main
+  // getter doesn't do.
+  static CastService* Create(
+      content::BrowserContext* browser_context,
+      net::URLRequestContextGetter* request_context_getter);

[gunsch, 2014/09/25 15:50:02]

Hm, is there any case where we actually want to change this parameter? Since
this is called by the content embedder, I would expect it to continue to always
pass in the same argument.

[lcwu1, 2014/09/25 17:07:37]

There are two reasons to pass in an url request context getter to CastService:
(1) CastService doesn't hold a reference to url_request_context_factory and the
request context getter in the browser_context is not (always) what we want, (2)
I want to keep CastService request_context_getter agnostic. That is, it just
uses the request context getter passed in in the constructor without having to
know what this context getter is (and how it is constructed). Currently we would
like to pass in the system context getter to the cast service, but it might
change if later we want to simplify the number of url request context getters
and pass in the main one.

 
   virtual ~CastService();
 
   // Start/stop the cast service.
   void Start();
   void Stop();
 
  protected:
   explicit CastService(content::BrowserContext* browser_context);
   virtual void Initialize() = 0;
 
   // Implementation-specific start/stop behavior.
   virtual void StartInternal() = 0;
   virtual void StopInternal() = 0;
 
   content::BrowserContext* browser_context() const { return browser_context_; }
 
  private:
   content::BrowserContext* const browser_context_;
   bool stopped_;
 
   const scoped_ptr<base::ThreadChecker> thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(CastService);
 };
 
 }  // namespace chromecast
 
 #endif  // CHROMECAST_SERVICE_CAST_SERVICE_H_