chrome/utility/importer/ie_importer_win.cc - Issue 606473002: Remove implicit HANDLE conversions from chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/ie_importer_win.cc

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/utility/importer/ie_importer_win.cc

diff --git a/chrome/utility/importer/ie_importer_win.cc b/chrome/utility/importer/ie_importer_win.cc

index fbefb18b3a1555b82b4a7b0c881a126ffc35548d..486997ddc96cfe31e505ba97fabac26da40208af 100644

--- a/chrome/utility/importer/ie_importer_win.cc

+++ b/chrome/utility/importer/ie_importer_win.cc

@@ -72,7 +72,9 @@ base::Time GetFileCreationTime(const base::string16& file) {

NULL, OPEN_EXISTING,

FILE_ATTRIBUTE_NORMAL | FILE_FLAG_BACKUP_SEMANTICS, NULL));

FILETIME creation_filetime;

- if (GetFileTime(file_handle, &creation_filetime, NULL, NULL))

+ if (!file_handle.IsValid())

+ return creation_time;

+ if (GetFileTime(file_handle.Get(), &creation_filetime, NULL, NULL))

creation_time = base::Time::FromFileTime(creation_filetime);

return creation_time;

}