Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10608)

Unified Diff: chrome/installer/util/user_experiment.cc

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/user_experiment.cc
diff --git a/chrome/installer/util/user_experiment.cc b/chrome/installer/util/user_experiment.cc
index 68e4eace8a6fd53696d4afc61ae0b50b79d1b572..7140237402536e78b85dd5280c2cdd2078b52699 100644
--- a/chrome/installer/util/user_experiment.cc
+++ b/chrome/installer/util/user_experiment.cc
@@ -84,7 +84,8 @@ int GetDirectoryWriteTimeInHours(const wchar_t* path) {
return -1;
FILETIME time;
- return ::GetFileTime(file, NULL, NULL, &time) ? FileTimeToHours(time) : -1;
+ return ::GetFileTime(file.Get(), NULL, NULL, &time) ?
+ FileTimeToHours(time) : -1;
Lei Zhang 2014/09/24 23:10:10 nit: indent 4 spaces from "return" ?
rvargas (doing something else) 2014/09/24 23:58:46 yeah, I've always hated indenting under a return a
}
// Returns the time in hours since the last write to the user data directory.
@@ -513,7 +514,7 @@ void InactiveUserToastExperiment(int flavor,
break;
default:
outcome = kToastExpTriesErrorGroup;
- };
+ }
// Write to the |client| key for the last time.
SetClient(experiment_group + outcome, true);

Powered by Google App Engine
This is Rietveld 408576698