Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 606413002: Remove duplicated code in android_get_gl_proc (Closed)

Created:
6 years, 2 months ago by JungJik
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove duplicated code in android_get_gl_proc. code for getting gles function pointer has been written twice. so this patch removes the last one. BUG=skia: Committed: https://skia.googlesource.com/skia/+/29fe24c0ed44c1ee8f21df16f4bdc058f27eab77

Patch Set 1 #

Patch Set 2 : remove white space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -194 lines) Patch
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 1 chunk +0 lines, -194 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JungJik
PTAL
6 years, 2 months ago (2014-10-02 06:09:18 UTC) #3
robertphillips
lgtm
6 years, 2 months ago (2014-10-02 11:54:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606413002/40001
6 years, 2 months ago (2014-10-02 11:55:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 12:28:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 29fe24c0ed44c1ee8f21df16f4bdc058f27eab77

Powered by Google App Engine
This is Rietveld 408576698