LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 60633008: [CSS Grid Layout] Percentages of indefinite sizes should compute to "auto" - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(138)

My Issues | Starred Open | Closed | All

Side by Side Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 60633008: [CSS Grid Layout] Percentages of indefinite sizes should compute to "auto" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css-grid-layout/resources/grid.css ('K') | « LayoutTests/fast/css-grid-layout/resources/grid.css ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 description('Test that setting and getting grid-definition-columns and grid-defi nition-rows works as expected');	1 description('Test that setting and getting grid-definition-columns and grid-defi nition-rows works as expected');

2	2

3 debug("Test getting grid-definition-columns and grid-definition-rows set through CSS");	3 debug("Test getting grid-definition-columns and grid-definition-rows set through CSS");

4 testGridDefinitionsValues(document.getElementById("gridWithNoneElement"), "none" , "none");	4 testGridDefinitionsValues(document.getElementById("gridWithNoneElement"), "none" , "none");

5 testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "10px ", "15px");	5 testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "10px ", "15px");

6 testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "40 0px", "150px");	6 testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "40 0px", "150px");

	7 testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "0px", "0px");

	8 testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSizeWit hChildren"), "7px", "11px");

7 testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "0px", "0px");	9 testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "0px", "0px");

8 testGridDefinitionsValues(document.getElementById("gridWithAutoWithoutSizeElemen t"), "0px", "0px");	10 testGridDefinitionsValues(document.getElementById("gridWithAutoWithoutSizeElemen t"), "0px", "0px");

9 testGridDefinitionsValues(document.getElementById("gridWithAutoWithChildrenEleme nt"), "7px", "11px");	11 testGridDefinitionsValues(document.getElementById("gridWithAutoWithChildrenEleme nt"), "7px", "11px");

10 testGridDefinitionsValues(document.getElementById("gridWithEMElement"), "100px", "150px");	12 testGridDefinitionsValues(document.getElementById("gridWithEMElement"), "100px", "150px");

11 testGridDefinitionsValues(document.getElementById("gridWithViewPortPercentageEle ment"), "64px", "60px");	13 testGridDefinitionsValues(document.getElementById("gridWithViewPortPercentageEle ment"), "64px", "60px");

12 testGridDefinitionsValues(document.getElementById("gridWithMinMaxElement"), "80p x", "300px");	14 testGridDefinitionsValues(document.getElementById("gridWithMinMaxElement"), "80p x", "300px");

13 testGridDefinitionsValues(document.getElementById("gridWithMinContentElement"), "0px", "0px");	15 testGridDefinitionsValues(document.getElementById("gridWithMinContentElement"), "0px", "0px");

14 testGridDefinitionsValues(document.getElementById("gridWithMinContentWithChildre nElement"), "17px", "11px");	16 testGridDefinitionsValues(document.getElementById("gridWithMinContentWithChildre nElement"), "17px", "11px");

15 testGridDefinitionsValues(document.getElementById("gridWithMaxContentElement"), "0px", "0px");	17 testGridDefinitionsValues(document.getElementById("gridWithMaxContentElement"), "0px", "0px");

16 testGridDefinitionsValues(document.getElementById("gridWithMaxContentWithChildre nElement"), "17px", "11px");	18 testGridDefinitionsValues(document.getElementById("gridWithMaxContentWithChildre nElement"), "17px", "11px");

(...skipping 101 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
118 element.style.gridDefinitionColumns = "initial";	120 element.style.gridDefinitionColumns = "initial";

119 element.style.gridDefinitionRows = "initial";	121 element.style.gridDefinitionRows = "initial";

120 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-co lumns')", "'none'");	122 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-co lumns')", "'none'");

121 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-ro ws')", "'none'");	123 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-ro ws')", "'none'");

122	124

123 document.body.removeChild(element);	125 document.body.removeChild(element);

124 }	126 }

125 debug("");	127 debug("");

126 debug("Test setting grid-definition-columns and grid-definition-rows to 'initial ' through JS");	128 debug("Test setting grid-definition-columns and grid-definition-rows to 'initial ' through JS");

127 testInitial();	129 testInitial();

OLD	NEW

« LayoutTests/fast/css-grid-layout/resources/grid.css ('K') | « LayoutTests/fast/css-grid-layout/resources/grid.css ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698