Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

Issue 60633008: [CSS Grid Layout] Percentages of indefinite sizes should compute to "auto" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« LayoutTests/fast/css-grid-layout/resources/grid.css ('K') | « LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 description('Test that setting and getting grid-definition-columns and grid-defi nition-rows works as expected'); 1 description('Test that setting and getting grid-definition-columns and grid-defi nition-rows works as expected');
2 2
3 debug("Test getting |grid-definition-columns| and |grid-definition-rows| set thr ough CSS"); 3 debug("Test getting |grid-definition-columns| and |grid-definition-rows| set thr ough CSS");
4 testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "7px 11px", "17px 2px"); 4 testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "7px 11px", "17px 2px");
5 testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "53 % 99%", "27% 52%", "424px 792px", "162px 312px"); 5 testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "53 % 99%", "27% 52%", "424px 792px", "162px 312px");
6 testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "53% 99%", "27% 52%", "7px 0px", "11px 0px");
6 testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "auto auto", "auto auto", "0px 17px", "0px 3px"); 7 testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "auto auto", "auto auto", "0px 17px", "0px 3px");
7 testGridDefinitionsValues(document.getElementById("gridWithEMElement"), "100px 1 20px", "150px 170px"); 8 testGridDefinitionsValues(document.getElementById("gridWithEMElement"), "100px 1 20px", "150px 170px");
8 testGridDefinitionsValues(document.getElementById("gridWithThreeItems"), "15px a uto 100px", "120px 18px auto", "15px 0px 100px", "120px 18px 0px"); 9 testGridDefinitionsValues(document.getElementById("gridWithThreeItems"), "15px a uto 100px", "120px 18px auto", "15px 0px 100px", "120px 18px 0px");
9 testGridDefinitionsValues(document.getElementById("gridWithPercentAndViewportPer cent"), "50% 120px", "35% 168px", "400px 120px", "210px 168px"); 10 testGridDefinitionsValues(document.getElementById("gridWithPercentAndViewportPer cent"), "50% 120px", "35% 168px", "400px 120px", "210px 168px");
10 testGridDefinitionsValues(document.getElementById("gridWithFitContentAndFitAvail able"), "none", "none"); 11 testGridDefinitionsValues(document.getElementById("gridWithFitContentAndFitAvail able"), "none", "none");
11 testGridDefinitionsValues(document.getElementById("gridWithMinMaxContent"), "min -content max-content", "max-content min-content", "0px 0px", "0px 0px"); 12 testGridDefinitionsValues(document.getElementById("gridWithMinMaxContent"), "min -content max-content", "max-content min-content", "0px 0px", "0px 0px");
12 testGridDefinitionsValues(document.getElementById("gridWithMinMaxContentWithChil drenElement"), "min-content max-content", "max-content min-content", "7px 17px", "11px 3px"); 13 testGridDefinitionsValues(document.getElementById("gridWithMinMaxContentWithChil drenElement"), "min-content max-content", "max-content min-content", "7px 17px", "11px 3px");
13 testGridDefinitionsValues(document.getElementById("gridWithMinMaxAndFixed"), "mi nmax(45px, 30%) 15px", "120px minmax(35%, 10px)", "240px 15px", "120px 210px"); 14 testGridDefinitionsValues(document.getElementById("gridWithMinMaxAndFixed"), "mi nmax(45px, 30%) 15px", "120px minmax(35%, 10px)", "240px 15px", "120px 210px");
14 testGridDefinitionsValues(document.getElementById("gridWithMinMaxAndMinMaxConten t"), "minmax(min-content, 30%) 15px", "120px minmax(35%, max-content)", "240px 1 5px", "120px 210px"); 15 testGridDefinitionsValues(document.getElementById("gridWithMinMaxAndMinMaxConten t"), "minmax(min-content, 30%) 15px", "120px minmax(35%, max-content)", "240px 1 5px", "120px 210px");
15 testGridDefinitionsValues(document.getElementById("gridWithFractionFraction"), " 1fr 2fr", "3fr 4fr", "320px 480px", "225px 375px"); 16 testGridDefinitionsValues(document.getElementById("gridWithFractionFraction"), " 1fr 2fr", "3fr 4fr", "320px 480px", "225px 375px");
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 element.style.gridDefinitionColumns = "initial"; 95 element.style.gridDefinitionColumns = "initial";
95 element.style.gridDefinitionRows = "initial"; 96 element.style.gridDefinitionRows = "initial";
96 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-co lumns')", "'none'"); 97 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-co lumns')", "'none'");
97 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-ro ws')", "'none'"); 98 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-ro ws')", "'none'");
98 99
99 document.body.removeChild(element); 100 document.body.removeChild(element);
100 } 101 }
101 debug(""); 102 debug("");
102 debug("Test setting grid-definition-columns and grid-definition-rows to 'initial ' through JS"); 103 debug("Test setting grid-definition-columns and grid-definition-rows to 'initial ' through JS");
103 testInitial(); 104 testInitial();
OLDNEW
« LayoutTests/fast/css-grid-layout/resources/grid.css ('K') | « LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698