Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 606153004: cc: set blender mode of TextureDrawQuad in nine_patch_layer_impl. (Closed)

Created:
6 years, 2 months ago by JungJik
Modified:
6 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_duplicate_code
Project:
chromium
Visibility:
Public.

Description

cc: Set opaque rect of TextureDrawQuad in NinePatchLayerImpl. We can know the resource opaqueness from UIResourceData. And if the resource is opaque such as jpeg or bmp, we can set opaque_rect to allow disabling blending if opaque. Committed: https://crrev.com/c9ca78264c5593114e116e58e76dbdb67e828a2d Cr-Commit-Position: refs/heads/master@{#304132}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : change to EXPECT_FALSE #

Patch Set 6 : Fix DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2 lines) Patch
M cc/layers/nine_patch_layer_impl.cc View 1 2 9 chunks +10 lines, -2 lines 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 1 2 3 4 5 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
JungJik
Please take a look. :)
6 years, 1 month ago (2014-11-12 11:27:37 UTC) #2
danakj
If there is no bug, just remove the BUG= line. The TEST= line is for ...
6 years, 1 month ago (2014-11-12 16:34:09 UTC) #3
JungJik
On 2014/11/12 16:34:09, danakj wrote: > If there is no bug, just remove the BUG= ...
6 years, 1 month ago (2014-11-13 03:22:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606153004/60001
6 years, 1 month ago (2014-11-13 03:25:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/16728)
6 years, 1 month ago (2014-11-13 03:34:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606153004/140001
6 years, 1 month ago (2014-11-13 23:07:01 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:140001)
6 years, 1 month ago (2014-11-14 01:10:55 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 01:11:14 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c9ca78264c5593114e116e58e76dbdb67e828a2d
Cr-Commit-Position: refs/heads/master@{#304132}

Powered by Google App Engine
This is Rietveld 408576698