[android] Password generation UI for android.

chrome/android/java/res/layout/password_generation_popup_suggestion.xml

Index: chrome/android/java/res/layout/password_generation_popup_suggestion.xml
diff --git a/chrome/android/java/res/layout/password_generation_popup_suggestion.xml b/chrome/android/java/res/layout/password_generation_popup_suggestion.xml
new file mode 100644
index 0000000000000000000000000000000000000000..72651822f9faff621edbd7cce294d33276b088b4
--- /dev/null
+++ b/chrome/android/java/res/layout/password_generation_popup_suggestion.xml
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2014 The Chromium Authors. All rights reserved.
+
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file.
+-->
+
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content">
+
+    <RelativeLayout android:id="@+id/password_generation_suggestion"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content">
+
+        <ImageView android:id="@+id/password_generation_icon"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginTop="@dimen/password_generation_icon_vertical_margin"

[aurimas (slooooooooow), 2014/10/23 00:57:01]

This dimen only seems to be used in this file. It would be easier to read if you
just inline it.

[please use gerrit instead, 2014/10/24 18:13:01]

Done.

+            android:layout_marginBottom="@dimen/password_generation_icon_vertical_margin"
+            android:layout_marginStart="@dimen/password_generation_horizontal_margin"
+            android:layout_marginEnd="@dimen/password_generation_horizontal_margin"
+            android:src="@drawable/infobar_savepassword_autologin"/>
+
+        <TextView android:id="@+id/password_generation_title"
+            android:layout_toEndOf="@id/password_generation_icon"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:paddingTop="@dimen/password_generation_text_vertical_margin"
+            android:paddingEnd="@dimen/password_generation_horizontal_margin"
+            android:singleLine="true"
+            android:textStyle="bold"
+            android:textColor="@color/default_text_color"
+            android:textSize="@dimen/password_generation_text_size"
+            android:includeFontPadding="false"/>
+
+        <TextView android:id="@+id/password_generation_password"
+            android:layout_toEndOf="@id/password_generation_icon"
+            android:layout_below="@id/password_generation_title"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:paddingBottom="@dimen/password_generation_text_vertical_margin"
+            android:paddingEnd="@dimen/password_generation_horizontal_margin"
+            android:singleLine="true"
+            android:textColor="@color/default_text_color"
+            android:textSize="@dimen/password_generation_text_size"
+            android:includeFontPadding="false"/>
+
+    </RelativeLayout>
+
+    <View android:id="@+id/password_generation_divider"

[aurimas (slooooooooow), 2014/10/23 00:57:01]

Could we actually use a real divider provided by ListPopupWindow? I think we
just need to call setDividerHeight and setDivider on the list view of the popup
window after we call show. Thoughts?

[please use gerrit instead, 2014/10/24 18:13:01]

setDivider() would require us to use DropdownDividerDrawable (or our own
implementation) and set its parameters like color and height. I prefer to keep
such styling information declared in this layout file instead. Would you be OK
with that?

[aurimas (slooooooooow), 2014/10/24 20:35:52]

You could do something like this in java:
ColorDrawable sage = new
ColorDrawable(this.getResources().getColor(R.color.my_favorite_color));
listView.setDivider(sage);

[please use gerrit instead, 2014/10/24 22:10:15]

I've tried both ColorDrawable and DropdownDividerDrawable. Neither show a
divider in the UI. (Of course, I removed setDividerHeight(0) in
DropdownPopupWindow first.) I'm not sure what sorcery is behind this behavior,
but it explains why DropdownPopupWindow resorts to drawing dividers by adding
DropdownDividerDrawable as elements in the popup instead of using setDivider()
directly.

+        android:layout_below="@id/password_generation_suggestion"
+        android:layout_width="wrap_content"
+        android:layout_height="@dimen/password_generation_divider_height"
+        android:background="@color/password_generation_divider_color"/>
+
+</RelativeLayout>