chrome/android/java/res/layout/password_generation_popup_suggestion.xml - Issue 606153002: [android] Password generation UI for android.

Side by Side Diff: chrome/android/java/res/layout/password_generation_popup_suggestion.xml

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set the width of the popup correctly. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/password_generation_popup_explanation.xml ('k') | chrome/android/java/res/layout/website_settings.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="wrap_content"

	10 android:layout_height="wrap_content">

	11

	12 <RelativeLayout android:id="@+id/password_generation_suggestion"

	13 android:layout_width="wrap_content"

	14 android:layout_height="wrap_content">

	15

	16 <ImageView android:id="@+id/password_generation_icon"

	17 android:layout_width="wrap_content"

	18 android:layout_height="wrap_content"

	19 android:layout_marginTop="@dimen/password_generation_icon_vertical_m argin"
	aurimas (slooooooooow) 2014/10/23 00:57:01 This dimen only seems to be used in this file. It This dimen only seems to be used in this file. It would be easier to read if you just inline it. please use gerrit instead 2014/10/24 18:13:01 Done. Show quoted text On 2014/10/23 00:57:01, aurimas wrote: > This dimen only seems to be used in this file. It would be easier to read if you > just inline it. Done.
	20 android:layout_marginBottom="@dimen/password_generation_icon_vertica l_margin"

	21 android:layout_marginStart="@dimen/password_generation_horizontal_ma rgin"

	22 android:layout_marginEnd="@dimen/password_generation_horizontal_marg in"

	23 android:src="@drawable/infobar_savepassword_autologin"/>

	24

	25 <TextView android:id="@+id/password_generation_title"

	26 android:layout_toEndOf="@id/password_generation_icon"

	27 android:layout_width="wrap_content"

	28 android:layout_height="wrap_content"

	29 android:paddingTop="@dimen/password_generation_text_vertical_margin"

	30 android:paddingEnd="@dimen/password_generation_horizontal_margin"

	31 android:singleLine="true"

	32 android:textStyle="bold"

	33 android:textColor="@color/default_text_color"

	34 android:textSize="@dimen/password_generation_text_size"

	35 android:includeFontPadding="false"/>

	36

	37 <TextView android:id="@+id/password_generation_password"

	38 android:layout_toEndOf="@id/password_generation_icon"

	39 android:layout_below="@id/password_generation_title"

	40 android:layout_width="wrap_content"

	41 android:layout_height="wrap_content"

	42 android:paddingBottom="@dimen/password_generation_text_vertical_marg in"

	43 android:paddingEnd="@dimen/password_generation_horizontal_margin"

	44 android:singleLine="true"

	45 android:textColor="@color/default_text_color"

	46 android:textSize="@dimen/password_generation_text_size"

	47 android:includeFontPadding="false"/>

	48

	49 </RelativeLayout>

	50

	51 <View android:id="@+id/password_generation_divider"
	aurimas (slooooooooow) 2014/10/23 00:57:01 Could we actually use a real divider provided by L Could we actually use a real divider provided by ListPopupWindow? I think we just need to call setDividerHeight and setDivider on the list view of the popup window after we call show. Thoughts? please use gerrit instead 2014/10/24 18:13:01 setDivider() would require us to use DropdownDivid Show quoted text On 2014/10/23 00:57:01, aurimas wrote: > Could we actually use a real divider provided by ListPopupWindow? I think we > just need to call setDividerHeight and setDivider on the list view of the popup > window after we call show. Thoughts? setDivider() would require us to use DropdownDividerDrawable (or our own implementation) and set its parameters like color and height. I prefer to keep such styling information declared in this layout file instead. Would you be OK with that? aurimas (slooooooooow) 2014/10/24 20:35:52 You could do something like this in java: ColorDra Show quoted text On 2014/10/24 18:13:01, Rouslan Solomakhin wrote: > On 2014/10/23 00:57:01, aurimas wrote: > > Could we actually use a real divider provided by ListPopupWindow? I think we > > just need to call setDividerHeight and setDivider on the list view of the > popup > > window after we call show. Thoughts? > > setDivider() would require us to use DropdownDividerDrawable (or our own > implementation) and set its parameters like color and height. I prefer to keep > such styling information declared in this layout file instead. Would you be OK > with that? You could do something like this in java: ColorDrawable sage = new ColorDrawable(this.getResources().getColor(R.color.my_favorite_color)); listView.setDivider(sage); please use gerrit instead 2014/10/24 22:10:15 I've tried both ColorDrawable and DropdownDividerD Show quoted text On 2014/10/24 20:35:52, aurimas wrote: > On 2014/10/24 18:13:01, Rouslan Solomakhin wrote: > > On 2014/10/23 00:57:01, aurimas wrote: > > > Could we actually use a real divider provided by ListPopupWindow? I think we > > > just need to call setDividerHeight and setDivider on the list view of the > > popup > > > window after we call show. Thoughts? > > > > setDivider() would require us to use DropdownDividerDrawable (or our own > > implementation) and set its parameters like color and height. I prefer to keep > > such styling information declared in this layout file instead. Would you be OK > > with that? > > You could do something like this in java: > ColorDrawable sage = new > ColorDrawable(this.getResources().getColor(R.color.my_favorite_color)); > listView.setDivider(sage); I've tried both ColorDrawable and DropdownDividerDrawable. Neither show a divider in the UI. (Of course, I removed setDividerHeight(0) in DropdownPopupWindow first.) I'm not sure what sorcery is behind this behavior, but it explains why DropdownPopupWindow resorts to drawing dividers by adding DropdownDividerDrawable as elements in the popup instead of using setDivider() directly.
	52 android:layout_below="@id/password_generation_suggestion"

	53 android:layout_width="wrap_content"

	54 android:layout_height="@dimen/password_generation_divider_height"

	55 android:background="@color/password_generation_divider_color"/>

	56

	57 </RelativeLayout>

OLD	NEW