Issue 60613005: Add got_revision support for apply_issue.

Issue 60613005: Add got_revision support for apply_issue. (Closed)

Created:
7 years, 1 month ago by ghost stip (do not use)

Modified:
7 years, 1 month ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, iannucci

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Add got_revision support for apply_issue. BUG=170427 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=236101

Patch Set 2 : Remove spurious comma. #

Total comments: 6

Patch Set 3 : Address maruel's comments. #

Patch Set 4 : Fix up docstring. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -4 lines)			Patch
	A	annotated_gclient.py	View	1 2 3	1 chunk	+89 lines, -0 lines	0 comments	Download
	M	apply_issue.py	View	1 2	5 chunks	+21 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

ghost stip (do not use)

(note: the apply_issue side is untested while I work on the buildbot side of this ...

7 years, 1 month ago (2013-11-19 22:41:04 UTC) #2

ghost stip (do not use)

updated: just tested apply_issue on https://chromiumcodereview.appspot.com/76803002/. apply_issue did the second gclient sync and output: @@@SET_BUILD_PROPERTY@got_v8_revision@17800@@@

7 years, 1 month ago (2013-11-19 22:47:24 UTC) #3

M-A Ruel

lgtm https://codereview.chromium.org/60613005/diff/50001/annotated_gclient.py File annotated_gclient.py (right): https://codereview.chromium.org/60613005/diff/50001/annotated_gclient.py#newcode6 annotated_gclient.py:6: """Wrap gclient calls with annotated output. Wraps :) ...

7 years, 1 month ago (2013-11-20 01:46:00 UTC) #4

ghost stip (do not use)

https://codereview.chromium.org/60613005/diff/50001/annotated_gclient.py File annotated_gclient.py (right): https://codereview.chromium.org/60613005/diff/50001/annotated_gclient.py#newcode25 annotated_gclient.py:25: def temp_filename(suffix): On 2013/11/20 01:46:01, M-A Ruel wrote: > ...

7 years, 1 month ago (2013-11-20 02:08:02 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/60613005/150001

7 years, 1 month ago (2013-11-20 02:12:29 UTC) #6

Message was sent while issue was closed.

Change committed as 236101

Expand Messages | Collapse Messages