Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2514)

Unified Diff: annotated_gclient.py

Issue 60613005: Add got_revision support for apply_issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Fix up docstring. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | apply_issue.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: annotated_gclient.py
diff --git a/annotated_gclient.py b/annotated_gclient.py
new file mode 100755
index 0000000000000000000000000000000000000000..1ed0f719a7f3bf5e05e82fe8a6ad2f56d8b129af
--- /dev/null
+++ b/annotated_gclient.py
@@ -0,0 +1,89 @@
+#!/usr/bin/env python
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Wraps gclient calls with annotated output.
+
+Note that you will have to use -- to stop option parsing for gclient flags.
+
+To run `gclient sync --gclientfile=.gclient` and annotate got_v8_revision:
+ `annotated_gclient.py --revision-mapping='{"src/v8": "got_v8_revision"}' --
+ sync --gclientfile=.gclient`
+"""
+
+import contextlib
+import json
+import optparse
+import os
+import subprocess
+import sys
+import tempfile
+
+
+@contextlib.contextmanager
+def temp_filename(suffix='', prefix='tmp'):
+ output_fd, output_file = tempfile.mkstemp(suffix=suffix, prefix=prefix)
+ os.close(output_fd)
+
+ yield output_file
+
+ try:
+ os.remove(output_file)
+ except OSError as e:
+ print 'Error cleaning up temp file %s: %s' % (output_file, e)
+
+
+def parse_got_revision(filename, revision_mapping):
+ result = {}
+ with open(filename) as f:
+ data = json.load(f)
+
+ for path, info in data['solutions'].iteritems():
+ # gclient json paths always end with a slash
+ path = path.rstrip('/')
+ if path in revision_mapping:
+ propname = revision_mapping[path]
+ result[propname] = info['revision']
+
+ return result
+
+
+def emit_buildprops(got_revisions):
+ for prop, revision in got_revisions.iteritems():
+ print '@@@SET_BUILD_PROPERTY@%s@%s@@@' % (prop, revision)
+
+
+def main():
+ parser = optparse.OptionParser(
+ description=('Runs gclient and annotates the output with any '
+ 'got_revisions.'))
+ parser.add_option('--revision-mapping', default='{}',
+ help='json dict of directory-to-property mappings.')
+ parser.add_option('--suffix', default='gclient',
+ help='tempfile suffix')
+ opts, args = parser.parse_args()
+
+ revision_mapping = json.loads(opts.revision_mapping)
+
+ if not args:
+ parser.error('Must provide arguments to gclient.')
+
+ if any(a.startswith('--output-json') for a in args):
+ parser.error('Can\'t call annotated_gclient with --output-json.')
+
+ with temp_filename(opts.suffix) as f:
+ cmd = ['gclient']
+ cmd.extend(args)
+ cmd.extend(['--output-json', f])
+ p = subprocess.Popen(cmd)
+ p.wait()
+
+ if p.returncode == 0:
+ revisions = parse_got_revision(f, revision_mapping)
+ emit_buildprops(revisions)
+ return p.returncode
+
+
+if __name__ == '__main__':
+ sys.exit(main())
« no previous file with comments | « no previous file | apply_issue.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698