Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 606113005: Move RenderViewHost swap out state to RenderFrameHost. (Closed)

Created:
6 years, 2 months ago by Charlie Reis
Modified:
6 years, 2 months ago
Reviewers:
jam, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move RenderViewHost swap out state to RenderFrameHost. Also tracks the number of active frames in a SiteInstance, rather than the number of views. These changes are necessary for tracking the pending swap-out state of frames. This involves a lot of test cleanup as well. BUG=418264 TEST=Subframes can swap out. (No visible behavior change.) Committed: https://crrev.com/cce56cd951f6685a0120db63418aa7e6d3df28f2 Cr-Commit-Position: refs/heads/master@{#297293}

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : Fix chrome/ compile #

Patch Set 4 : Fix typo #

Patch Set 5 : Fix all but CrossSiteIframe test #

Patch Set 6 : Fix CrossSiteIframe test. #

Total comments: 25

Patch Set 7 : Fix review suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -646 lines) Patch
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 4 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 3 4 7 chunks +9 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 4 5 6 7 chunks +76 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 26 chunks +118 lines, -63 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 4 5 6 9 chunks +34 lines, -38 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 2 3 4 5 6 40 chunks +172 lines, -168 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 11 chunks +26 lines, -83 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 17 chunks +14 lines, -130 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/site_instance_impl.h View 1 2 chunks +14 lines, -15 lines 0 comments Download
M content/browser/site_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 7 chunks +18 lines, -19 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 4 24 chunks +34 lines, -48 lines 0 comments Download
M content/public/test/test_renderer_host.h View 1 2 3 4 5 6 2 chunks +9 lines, -10 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/test_render_frame_host.cc View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M content/test/test_render_view_host.h View 1 2 3 4 2 chunks +0 lines, -14 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M content/test/test_web_contents.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Charlie Reis
Nasko: I think this is finally ready for review! It was tricky to move some ...
6 years, 2 months ago (2014-09-29 16:52:57 UTC) #2
nasko
This is awesome! I can't wait for RVH to be completely eliminated from navigations and ...
6 years, 2 months ago (2014-09-29 20:28:10 UTC) #3
Charlie Reis
Thanks! New patch uploaded. https://codereview.chromium.org/606113005/diff/100001/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/606113005/diff/100001/content/browser/frame_host/render_frame_host_impl.cc#newcode336 content/browser/frame_host/render_frame_host_impl.cc:336: // TODO(nasko): Only check RenderViewHost ...
6 years, 2 months ago (2014-09-29 20:49:21 UTC) #4
nasko
LGTM!
6 years, 2 months ago (2014-09-29 21:53:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606113005/120001
6 years, 2 months ago (2014-09-29 21:56:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14229)
6 years, 2 months ago (2014-09-29 22:05:33 UTC) #9
Charlie Reis
jam: Can you take a quick look at browser_with_test_window_test.cc for owners?
6 years, 2 months ago (2014-09-29 22:09:41 UTC) #11
jam
On 2014/09/29 22:09:41, Charlie Reis wrote: > jam: Can you take a quick look at ...
6 years, 2 months ago (2014-09-29 22:24:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606113005/120001
6 years, 2 months ago (2014-09-29 22:26:15 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001) as c74391e5802ba257a2732805fd0628925feb1383
6 years, 2 months ago (2014-09-29 22:45:29 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 22:48:22 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/cce56cd951f6685a0120db63418aa7e6d3df28f2
Cr-Commit-Position: refs/heads/master@{#297293}

Powered by Google App Engine
This is Rietveld 408576698