content/browser/renderer_host/render_view_host_unittest.cc - Issue 606113005: Move RenderViewHost swap out state to RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 606113005: Move RenderViewHost swap out state to RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review suggestions Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_unittest.cc

diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc

index b2cd8a8b6cc66f1daa7f94e0fa8b20f0b8015de1..be0a1d8755ab47d6845fbb4ca7aeafeb7928e1cc 100644

--- a/content/browser/renderer_host/render_view_host_unittest.cc

+++ b/content/browser/renderer_host/render_view_host_unittest.cc

@@ -99,11 +99,11 @@ TEST_F(RenderViewHostTest, ResetUnloadOnReload) {

url2, Referrer(), ui::PAGE_TRANSITION_LINK, std::string());

// Simulate the ClosePage call which is normally sent by the net::URLRequest.

rvh()->ClosePage();

- // Needed so that navigations are not suspended on the RVH.

- test_rvh()->SendBeforeUnloadACK(true);

+ // Needed so that navigations are not suspended on the RFH.

+ main_test_rfh()->SendBeforeUnloadACK(true);

contents()->Stop();

controller().Reload(false);

- EXPECT_FALSE(test_rvh()->IsWaitingForUnloadACK());

+ EXPECT_FALSE(main_test_rfh()->IsWaitingForUnloadACK());

}

// Ensure we do not grant bindings to a process shared with unprivileged views.

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »