Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 606113003: Revert of Make cc output surface creation async (Closed)

Created:
6 years, 2 months ago by kareng
Modified:
6 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

Revert of Make cc output surface creation async (patchset #12 id:220001 of https://codereview.chromium.org/348093004/) Reason for revert: possibly causing bug=418206 crash. Original issue's description: > Make cc output surface creation async > > As a part of making Android CompositorImpl use cc's scheduler and not > post its own composite calls manually, cc needs to be able to handle > asynchronous output surface creation. > > This change modifies CreateOutputSurface to instead be > RequestNewOutputSurface, which the LayerTreeHostClient must respond to > and call SetOutputSurface on the host with the new output surface once > it is ready. > > Because the LayerTreeHostClient must now talk to the host as a part of > output surface creation, a bunch of unit test code needed to be > refactored to handle this. > > BUG=none > > Committed: https://crrev.com/2097cab4982cc0ad92b878ad88e39d724dd047f7 > Cr-Commit-Position: refs/heads/master@{#296780} TBR=boliu@chromium.org,brianderson@chromium.org,danakj@chromium.org,jamesr@chromium.org,sievers@chromium.org,jcivelli@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -370 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/browser/hardware_renderer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/blink/web_layer_impl_fixed_bounds_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/debug/micro_benchmark_controller_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M cc/layers/contents_scaling_layer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/delegated_renderer_layer_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/layers/layer_iterator_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M cc/layers/layer_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 8 chunks +8 lines, -16 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 chunk +9 lines, -16 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 3 chunks +1 line, -6 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.cc View 2 chunks +12 lines, -19 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_test_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_test_common.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/layer_tree_host_common_test.h View 3 chunks +0 lines, -5 lines 0 comments Download
M cc/test/layer_tree_host_common_test.cc View 2 chunks +1 line, -8 lines 0 comments Download
M cc/test/layer_tree_test.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 chunk +3 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 66 chunks +66 lines, -67 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 8 chunks +2 lines, -60 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +15 lines, -28 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_host.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kareng
Created Revert of Make cc output surface creation async
6 years, 2 months ago (2014-09-26 20:22:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606113003/1
6 years, 2 months ago (2014-09-26 20:23:09 UTC) #2
enne (OOO)
6 years, 2 months ago (2014-10-01 18:32:30 UTC) #5
This never landed; closing it.

Powered by Google App Engine
This is Rietveld 408576698