Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 606033003: Fix RenderWidgetHostViewAuraTest.* for Surfaces (Closed)

Created:
6 years, 2 months ago by jbauman
Modified:
6 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix RenderWidgetHostViewAuraTest.* for Surfaces Mostly change things to check for existence of surface id as well as a frame provider. Also fix compositor lock handling and OnDelegatedFrameDamage handling. Committed: https://crrev.com/a54faef58152b6d384336d10e31b7d1f3c136682 Cr-Commit-Position: refs/heads/master@{#297080}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -34 lines) Patch
M content/browser/compositor/delegated_frame_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 13 chunks +56 lines, -29 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years, 2 months ago (2014-09-26 23:03:47 UTC) #2
piman
lgtm
6 years, 2 months ago (2014-09-26 23:55:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606033003/20001
6 years, 2 months ago (2014-09-27 00:00:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 835a9c182ee25e042d19a68e8bcd701a05b3256a
6 years, 2 months ago (2014-09-27 00:05:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 00:06:08 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a54faef58152b6d384336d10e31b7d1f3c136682
Cr-Commit-Position: refs/heads/master@{#297080}

Powered by Google App Engine
This is Rietveld 408576698