Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: content/browser/compositor/delegated_frame_host.cc

Issue 606033003: Fix RenderWidgetHostViewAuraTest.* for Surfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/delegated_frame_host.cc
diff --git a/content/browser/compositor/delegated_frame_host.cc b/content/browser/compositor/delegated_frame_host.cc
index 70b93ae08e9f8ddb6a36c3e7d02eae4367211681..07ae8175c5d18632fa3afb0c2228e822117d4d6c 100644
--- a/content/browser/compositor/delegated_frame_host.cc
+++ b/content/browser/compositor/delegated_frame_host.cc
@@ -433,11 +433,8 @@ void DelegatedFrameHost::SwapDelegatedFrame(
current_frame_size_in_dip_ = frame_size_in_dip;
CheckResizeLock();
- if (modified_layers && !damage_rect_in_dip.IsEmpty()) {
- // TODO(jbauman): Need to always tell the window observer about the
- // damage.
+ if (!damage_rect_in_dip.IsEmpty())
client_->GetLayer()->OnDelegatedFrameDamage(damage_rect_in_dip);
- }
pending_delegated_ack_count_++;
@@ -457,6 +454,8 @@ void DelegatedFrameHost::SwapDelegatedFrame(
base::Bind(&DelegatedFrameHost::SendDelegatedFrameAck,
AsWeakPtr(),
output_surface_id));
+ } else {
+ AddOnCommitCallbackAndDisableLocks(base::Closure());
}
DidReceiveFrameFromRenderer(damage_rect);
if (frame_provider_.get() || !surface_id_.is_null())
@@ -939,7 +938,8 @@ void DelegatedFrameHost::AddOnCommitCallbackAndDisableLocks(
compositor->AddObserver(this);
can_lock_compositor_ = NO_PENDING_COMMIT;
- on_compositing_did_commit_callbacks_.push_back(callback);
+ if (!callback.is_null())
+ on_compositing_did_commit_callbacks_.push_back(callback);
}
void DelegatedFrameHost::AddedToWindow() {

Powered by Google App Engine
This is Rietveld 408576698