Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 606013004: Stop doing at-exit cleanup of lazy pointers. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Stop doing at-exit cleanup of lazy pointers. There are only a fixed number of them, and we're already intentionally leaking in Release. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot BUG=skia:2940 Committed: https://skia.googlesource.com/skia/+/c7eb58c8b46c72cca3cea1582c7f860293a1cbe9

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : re-rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M src/core/SkLazyPtr.h View 1 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
mtklein
6 years, 2 months ago (2014-09-26 18:59:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606013004/1
6 years, 2 months ago (2014-09-26 19:01:26 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-26 19:01:27 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-26 19:04:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606013004/1
6 years, 2 months ago (2014-09-26 19:34:01 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-26 19:34:02 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-09-27 01:34:08 UTC) #12
reed1
deferring to Ben
6 years, 2 months ago (2014-09-29 12:39:41 UTC) #14
mtklein
On 2014/09/29 12:39:41, reed1 wrote: > deferring to Ben Ping!
6 years, 2 months ago (2014-10-14 14:47:17 UTC) #15
mtklein
The Sheriff-hat-wearing aspect of me is going to land this. Let's follow up if you ...
6 years, 2 months ago (2014-10-20 14:30:29 UTC) #16
mtklein
lgtm
6 years, 2 months ago (2014-10-20 14:30:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606013004/40001
6 years, 2 months ago (2014-10-20 14:31:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606013004/40001
6 years, 2 months ago (2014-10-20 19:35:29 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:07:07 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as c7eb58c8b46c72cca3cea1582c7f860293a1cbe9

Powered by Google App Engine
This is Rietveld 408576698