Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 605953002: Improve robustness of RenderCombine emphasis mark replacement character (Closed)

Created:
5 years, 6 months ago by Dominik Röttsches
Modified:
5 years, 6 months ago
Reviewers:
behdad_google, eae, behdad
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Improve robustness of RenderCombine emphasis mark replacement character Emphasis marks on RenderCombine objects are drawn using a fake text run containing one replacement character which should match the horizontal, compressed digits in size. The object replacement character U+FFFC, which was used before, does not reliably fulfill this requirement, the ideographic space works better. BUG=418026 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182756

Patch Set 1 #

Patch Set 2 : Rebaselines to TestExpecations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/TextPainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dominik Röttsches
5 years, 6 months ago (2014-09-26 10:54:27 UTC) #2
eae
Awsome, LGTM
5 years, 6 months ago (2014-09-26 11:09:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605953002/20001
5 years, 6 months ago (2014-09-26 11:10:19 UTC) #5
behdad_google
lgtm
5 years, 6 months ago (2014-09-26 11:41:32 UTC) #7
behdad_google
lgtm I like this!
5 years, 6 months ago (2014-09-26 11:44:03 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2014-09-26 12:15:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182756

Powered by Google App Engine
This is Rietveld 408576698