Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issue 605893002: Revert of Changes NineImagePainter to snap to (enclosed) pixel boundaries (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
Reviewers:
ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Changes NineImagePainter to snap to (enclosed) pixel boundaries (patchset #2 id:20001 of https://codereview.chromium.org/604463003/) Reason for revert: I'm reverting this as there are two issues: 1. Translate isn't being set correctly. 2. Even with 1 fixed there are problems with scrollbars. I'll investigate after the revert. Original issue's description: > Changes NineImagePainter to snap to (enclosed) pixel boundaries > > Otherwise the sides may be clipped out. > > BUG=417493 > TEST=see bug > R=ananta@chromium.org > > Committed: https://crrev.com/d1ab0241ee29c70bd08531d1f038964664b124b6 > Cr-Commit-Position: refs/heads/master@{#296608} TBR=ananta@chromium.org NOTREECHECKS=true NOTRY=true BUG=417493 Committed: https://crrev.com/70d0d490c16f1eda44e3d06cc54aad9911b03cc1 Cr-Commit-Position: refs/heads/master@{#296839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -44 lines) Patch
M ui/gfx/canvas.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M ui/gfx/nine_image_painter.cc View 3 chunks +20 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Changes NineImagePainter to snap to (enclosed) pixel boundaries
6 years, 2 months ago (2014-09-26 00:08:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605893002/1
6 years, 2 months ago (2014-09-26 00:11:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0cdd6daff3d53ab6dc5976c43723df65628acd4f
6 years, 2 months ago (2014-09-26 00:12:29 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 00:13:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70d0d490c16f1eda44e3d06cc54aad9911b03cc1
Cr-Commit-Position: refs/heads/master@{#296839}

Powered by Google App Engine
This is Rietveld 408576698