Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: media/base/android/media_codec_bridge.cc

Issue 605883002: Fix wrong selection of VP8 video decoder on some Samsung devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_bridge.cc
diff --git a/media/base/android/media_codec_bridge.cc b/media/base/android/media_codec_bridge.cc
index 7ece5d558e6fa03937e5efc3b6fb1a1d5cbcccfb..77a52b8f54e9922277269074eae46eae62672992 100644
--- a/media/base/android/media_codec_bridge.cc
+++ b/media/base/android/media_codec_bridge.cc
@@ -175,9 +175,13 @@ bool MediaCodecBridge::IsKnownUnaccelerated(const std::string& mime_type,
codecs_info[i].direction == direction) {
// It would be nice if MediaCodecInfo externalized some notion of
// HW-acceleration but it doesn't. Android Media guidance is that the
- // prefix below is always used for SW decoders, so that's what we use.
- if (!StartsWithASCII(codecs_info[i].name, "OMX.google.", true))
- return false;
+ // "OMX.google" prefix is always used for SW decoders, so that's what we
+ // use. "OMX.SEC.vp8.dec" codec don't work when trying to decode to a
+ // surface, so report it as SW decoder as well.
qinmin 2014/09/26 05:00:28 the comments is wierd. This function is checking w
AlexGlaznev 2014/09/26 18:01:37 Done.
+ DVLOG(1) << __PRETTY_FUNCTION__ << "Default codec for " << mime_type <<
+ ": " << codecs_info[i].name;
+ return (StartsWithASCII(codecs_info[i].name, "OMX.google.", true) ||
+ StartsWithASCII(codecs_info[i].name, "OMX.SEC.", true));
}
}
return true;

Powered by Google App Engine
This is Rietveld 408576698