Fix wrong selection of VP8 video decoder on some Samsung devices.

media/base/android/media_codec_bridge.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_codec_bridge.h"
 
 #include <jni.h>
 #include <string>
 
 #include "base/android/build_info.h"
@@ skipping 157 matching lines @@
     return true;
 
   std::string codec_type = AndroidMimeTypeToCodecType(mime_type);
   std::vector<media::MediaCodecBridge::CodecsInfo> codecs_info =
       MediaCodecBridge::GetCodecsInfo();
   for (size_t i = 0; i < codecs_info.size(); ++i) {
     if (codecs_info[i].codecs == codec_type &&
         codecs_info[i].direction == direction) {
       // It would be nice if MediaCodecInfo externalized some notion of
       // HW-acceleration but it doesn't. Android Media guidance is that the
-      // prefix below is always used for SW decoders, so that's what we use.
-      if (!StartsWithASCII(codecs_info[i].name, "OMX.google.", true))
-        return false;
+      // "OMX.google" prefix is always used for SW decoders, so that's what we
+      // use. "OMX.SEC.vp8.dec" codec don't work when trying to decode to a
+      // surface, so report it as SW decoder as well.

[qinmin, 2014/09/26 05:00:28]

the comments is wierd. This function is checking whether the decoder is HW
accelerated or not, it has nothing to do with whether it can decode to a
surface.
The only place that we call this function is android_video_decode_accelerator.cc
and android_video_encode_accelerator.cc

[AlexGlaznev, 2014/09/26 18:01:37]

Done.

+      DVLOG(1) << __PRETTY_FUNCTION__ << "Default codec for " << mime_type <<
+          ": " << codecs_info[i].name;
+      return (StartsWithASCII(codecs_info[i].name, "OMX.google.", true) ||
+          StartsWithASCII(codecs_info[i].name, "OMX.SEC.", true));
     }
   }
   return true;
 }
 
 MediaCodecBridge::MediaCodecBridge(const std::string& mime,
                                    bool is_secure,
                                    MediaCodecDirection direction) {
   JNIEnv* env = AttachCurrentThread();
   CHECK(env);
@@ skipping 547 matching lines @@
   JNIEnv* env = AttachCurrentThread();
   return Java_MediaCodecBridge_isAdaptivePlaybackSupported(
       env, media_codec(), width, height);
 }
 
 bool MediaCodecBridge::RegisterMediaCodecBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace media