Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 605843002: Rename SkImage::draw(_, SkRect, SkRect) in SkImage::drawRect() (Closed)

Created:
6 years, 2 months ago by Rémi Piotaix
Modified:
6 years, 2 months ago
Reviewers:
Justin Novosad, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@skimage_draw_forgot
Project:
skia
Visibility:
Public.

Description

Rename SkImage::draw(_, SkRect, SkRect) in SkImage::drawRect() BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/5ceff913cfd458c653358db7f60e995f505bce84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M include/core/SkImage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Rémi Piotaix
PTAL
6 years, 2 months ago (2014-09-25 21:24:26 UTC) #2
reed1
For non-virtual (private) methods, we have a fine history of using polymorphic functions. Is there ...
6 years, 2 months ago (2014-09-26 12:57:54 UTC) #3
Rémi Piotaix
On 2014/09/26 12:57:54, reed1 wrote: > For non-virtual (private) methods, we have a fine history ...
6 years, 2 months ago (2014-09-26 14:01:33 UTC) #4
reed1
I think that is of minor value, esp. since its internal, but ok, lets also ...
6 years, 2 months ago (2014-09-26 14:09:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605843002/1
6 years, 2 months ago (2014-09-26 14:11:23 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 14:36:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 5ceff913cfd458c653358db7f60e995f505bce84

Powered by Google App Engine
This is Rietveld 408576698