Land Recent QUIC Changes.

Land Recent QUIC Changes.

Remove loss detection from QuicConfig now that connection options has
replaced it.

Merge internal change: 75952172

Chromium specific changes:
+ Deleted enable_quic_time_based_loss_detection from
  NetworkSession params.
+ Deleted enable-quic-time-based-loss-detection and
  disable-quic-time-based-loss-detection command line
  switches.

https://codereview.chromium.org/591323003/

Do not timeout QUIC connections when settings the timeouts from
InitializeSession(). Protected by FLAG_quic_timeouts_only_from_alarms

Removes FLAG_quic_timeouts_require_activity which was somewhat broken.

Merge internal change: 75927669
https://codereview.chromium.org/605903002/

Factor out the QUIC timeout alarm setting logic from the CheckForTimeout
method into a new SetTimeout method.

- no behavior change, simply moving QUIC timeout alarm code.

Merge internal change: 75915264
https://codereview.chromium.org/593193005/

Add a timestamp field to QUIC's CachedNetworkParams proto message.

Context in b/17357338, follow-up CL will store CachedNetworkParams and
copy into newly created STKs.

Merge internal change: 75897792
https://codereview.chromium.org/604173002/

Call QuicSentPacketManager's OnPacketSent method and make
OnRetransmittedPacket and OnSerializedPacket private.

Merge internal change: 75830237
https://codereview.chromium.org/593193004/

Change the return type of QuicConnection::CheckForTimeout from bool to
void since it is unused.

Merge internal change: 75724127
https://codereview.chromium.org/604163002/

Test-only.  Remove calls to OnSerializedPacket from
QuicSentPacketManagerTest, in preparation for OnSerializedPacket to be
removed.

Merge internal change: 75716236
https://codereview.chromium.org/600823006/

R=rch@chromium.org, sky@chromium.org

Added sky@ for OWNERS approval for chrome/browser and chrome/common
changes

Committed: https://crrev.com/a4dcff92312b99670e9a19657f881b00a0404e69
Cr-Commit-Position: refs/heads/master@{#297208}

[sky, 2014-09-26 16:02:37]

chrome LGTM

[ramant (doing other things), 2014-09-26 17:55:32]

Updated this CL with  WithTimeBasedLossDetection field trial changes.

PTAL.

thanks
raman

[ramant (doing other things), 2014-09-26 18:07:10]

On 2014/09/26 17:55:32, ramant wrote:
> Updated this CL with  WithTimeBasedLossDetection field trial changes.
> 
> PTAL.
> 
> thanks
> raman

Hi Ryan and Ian,
  Do we need to land this before the branch for M39 is cut?

thanks
raman

[Ian Swett, 2014-09-26 18:13:38]

ianswett@google.com changed reviewers:
+ ianswett@google.com

[Ian Swett, 2014-09-26 18:13:39]

I don't think it's critical, but Ryan may disagree.

[sky, 2014-09-26 19:46:24]

SLGTM

[ramant (doing other things), 2014-09-26 22:28:45]

Hi Ryan,
  Reverted Patch Set 3. Patch Set 4 is same as Patch Set 1 (which is a merge of
all CL's) and enabled FLAGS_quic_timeouts_only_from_alarms.

PTAL.

thanks
raman

[Ryan Hamilton, 2014-09-26 23:37:25]

lgtm

[ramant (doing other things), 2014-09-29 17:07:58]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-09-29 17:08:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605733006/60001

[commit-bot: I haz the power, 2014-09-29 18:16:15]

Committed patchset #4 (id:60001) as 136c5ee964dd96ef9ffaeda9dba5c2d1f56c5fdc

[commit-bot: I haz the power, 2014-09-29 18:17:40]

Patchset 4 (id:??) landed as
https://crrev.com/a4dcff92312b99670e9a19657f881b00a0404e69
Cr-Commit-Position: refs/heads/master@{#297208}