Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3637)

Unified Diff: chrome/browser/io_thread.cc

Issue 605733006: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert Patch Set 3 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 5ce6ca780def8e55125d730404a60dc209e64e4f..d42723ed6d9935199ba21a782ac4f1a7f6bb9f84 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -122,8 +122,6 @@ const char kQuicFieldTrialEnabledGroupName[] = "Enabled";
const char kQuicFieldTrialHttpsEnabledGroupName[] = "HttpsEnabled";
const char kQuicFieldTrialPacketLengthSuffix[] = "BytePackets";
const char kQuicFieldTrialPacingSuffix[] = "WithPacing";
-const char kQuicFieldTrialTimeBasedLossDetectionSuffix[] =
- "WithTimeBasedLossDetection";
// The SPDY trial composes two different trial plus control groups:
// * A "holdback" group with SPDY disabled, and corresponding control
@@ -1015,8 +1013,6 @@ void IOThread::InitializeNetworkSessionParamsFromGlobals(
&params->enable_websocket_over_spdy);
globals.enable_quic.CopyToIfSet(&params->enable_quic);
- globals.enable_quic_time_based_loss_detection.CopyToIfSet(
- &params->enable_quic_time_based_loss_detection);
globals.quic_always_require_handshake_confirmation.CopyToIfSet(
&params->quic_always_require_handshake_confirmation);
globals.quic_disable_connection_pooling.CopyToIfSet(
@@ -1169,9 +1165,6 @@ void IOThread::ConfigureQuicGlobals(
bool enable_quic = ShouldEnableQuic(command_line, quic_trial_group);
globals->enable_quic.set(enable_quic);
if (enable_quic) {
- globals->enable_quic_time_based_loss_detection.set(
- ShouldEnableQuicTimeBasedLossDetection(command_line, quic_trial_group,
- quic_trial_params));
globals->quic_always_require_handshake_confirmation.set(
ShouldQuicAlwaysRequireHandshakeConfirmation(quic_trial_params));
globals->quic_disable_connection_pooling.set(
@@ -1334,26 +1327,6 @@ double IOThread::GetAlternateProtocolProbabilityThreshold(
}
// static
-bool IOThread::ShouldEnableQuicTimeBasedLossDetection(
- const CommandLine& command_line,
- base::StringPiece quic_trial_group,
- const VariationParameters& quic_trial_params) {
- if (command_line.HasSwitch(switches::kEnableQuicTimeBasedLossDetection))
- return true;
-
- if (command_line.HasSwitch(switches::kDisableQuicTimeBasedLossDetection))
- return false;
-
- if (LowerCaseEqualsASCII(
- GetVariationParam(quic_trial_params, "enable_time_based_loss_detection"),
- "true"))
- return true;
-
- return quic_trial_group.ends_with(
- kQuicFieldTrialTimeBasedLossDetectionSuffix);
-}
-
-// static
bool IOThread::ShouldQuicAlwaysRequireHandshakeConfirmation(
const VariationParameters& quic_trial_params) {
return LowerCaseEqualsASCII(
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698