PRESUBMIT.py - Issue 60573010: Make presumbit warnings ignore symbols that start with UNIT_TEST - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(90)

My Issues | Starred Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 60573010: Make presumbit warnings ignore symbols that start with UNIT_TEST (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 2836a98e46eb79826de5090fa336beb0072320eb..aa870227bc6e7086b513147a6c806391b87c7735 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -296,7 +296,10 @@ def _CheckNoUNIT_TESTInSourceFiles(input_api, output_api):

continue

for line_num, line in f.ChangedContents():

- if 'UNIT_TEST' in line:

+ if 'UNIT_TEST ' in line:

Jói 2013/11/18 06:41:19 Suggest combining these conditionals since the act

rvargas (doing something else) 2013/11/18 19:07:37 :) done

+ problems.append(' %s:%d' % (f.LocalPath(), line_num))

+

+ if line.endswith('UNIT_TEST'):

problems.append(' %s:%d' % (f.LocalPath(), line_num))

if not problems:

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698