Make presumbit warnings ignore symbols that start with UNIT_TEST

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 278 matching lines @@
 
 
 def _CheckNoUNIT_TESTInSourceFiles(input_api, output_api):
   """Checks to make sure no source files use UNIT_TEST"""
   problems = []
   for f in input_api.AffectedFiles():
     if (not f.LocalPath().endswith(('.cc', '.mm'))):
       continue
 
     for line_num, line in f.ChangedContents():
-      if 'UNIT_TEST' in line:
+      if 'UNIT_TEST ' in line:

[Jói, 2013/11/18 06:41:19]

Suggest combining these conditionals since the action is the same for both:

if 'UNIT_TEST ' in line or line.endswith('UNIT_TEST'):
  ...

[rvargas (doing something else), 2013/11/18 19:07:37]

:) done

+        problems.append('    %s:%d' % (f.LocalPath(), line_num))
+
+      if line.endswith('UNIT_TEST'):
         problems.append('    %s:%d' % (f.LocalPath(), line_num))
 
   if not problems:
     return []
   return [output_api.PresubmitPromptWarning('UNIT_TEST is only for headers.\n' +
       '\n'.join(problems))]
 
 
 def _CheckNoNewWStrings(input_api, output_api):
   """Checks to make sure we don't introduce use of wstrings."""
@@ skipping 767 matching lines @@
     trybots += ['cros_x86']
 
   # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
   # unless they're .gyp(i) files as changes to those files can break the gyp
   # step on that bot.
   if (not all(re.search('^chrome', f) for f in files) or
       any(re.search('\.gypi?$', f) for f in files)):
     trybots += ['android_aosp']
 
   return trybots