Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 60573010: Make presumbit warnings ignore symbols that start with UNIT_TEST (Closed)

Created:
7 years, 1 month ago by rvargas (doing something else)
Modified:
7 years, 1 month ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Make presumbit warnings ignore symbols that start with UNIT_TEST UNIT_TEST_MODE was being flagged as use of UNIT_TEST on a cc file. NOTRY=true R=joi@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235987

Patch Set 1 #

Total comments: 2

Patch Set 2 : single if #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rvargas (doing something else)
7 years, 1 month ago (2013-11-16 03:33:54 UTC) #1
Jói
https://codereview.chromium.org/60573010/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/60573010/diff/1/PRESUBMIT.py#newcode299 PRESUBMIT.py:299: if 'UNIT_TEST ' in line: Suggest combining these conditionals ...
7 years, 1 month ago (2013-11-18 06:41:18 UTC) #2
rvargas (doing something else)
thanks https://codereview.chromium.org/60573010/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/60573010/diff/1/PRESUBMIT.py#newcode299 PRESUBMIT.py:299: if 'UNIT_TEST ' in line: On 2013/11/18 06:41:19, ...
7 years, 1 month ago (2013-11-18 19:07:37 UTC) #3
Jói
LGTM
7 years, 1 month ago (2013-11-19 12:30:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/60573010/60001
7 years, 1 month ago (2013-11-19 12:30:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=156457
7 years, 1 month ago (2013-11-19 12:57:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/60573010/60001
7 years, 1 month ago (2013-11-19 12:59:54 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 13:00:07 UTC) #8
Message was sent while issue was closed.
Change committed as 235987

Powered by Google App Engine
This is Rietveld 408576698