Autofill browser_tests: set autofilled property after autofilled value is set.

Autofill browser_tests: set autofilled property after autofilled value is set.

R=isherman@chromium.org
BUG=412311
Committed: https://crrev.com/ca4f42145c27772afd077eda57bc36d0abc4e483
Cr-Commit-Position: refs/heads/master@{#297020}

[ziran.sun, 2014-09-25 09:21:06]

Please review. Thanks!

[Ilya Sherman, 2014-09-25 22:31:14]

https://codereview.chromium.org/605683002/diff/1/chrome/renderer/autofill/for...
File chrome/renderer/autofill/form_autofill_browsertest.cc (right):

https://codereview.chromium.org/605683002/diff/1/chrome/renderer/autofill/for...
chrome/renderer/autofill/form_autofill_browsertest.cc:3210:
web_frame->document().getElementById("state").to<WebInputElement>();
Hmm... how are we even able to cast to WebInputElement?  AFAICT, that's not a
parent class for this element.

https://codereview.chromium.org/605683002/diff/1/chrome/renderer/autofill/for...
chrome/renderer/autofill/form_autofill_browsertest.cc:3211:
state.setAutofilled(true);
I'd suggest combining lines 3203 through 3211 as

// Set the value and autofilled attribute of the state element.
WebSelectElement state =
    web_frame->document().getElementById("state").to<WebSelectElement>();
state.setValue(WebString::fromUTF8("AK"));
state.setAutofilled(true);

[ziran.sun, 2014-09-26 09:34:41]

Update code as per review comments. Please review. Thanks!

https://codereview.chromium.org/605683002/diff/1/chrome/renderer/autofill/for...
File chrome/renderer/autofill/form_autofill_browsertest.cc (right):

https://codereview.chromium.org/605683002/diff/1/chrome/renderer/autofill/for...
chrome/renderer/autofill/form_autofill_browsertest.cc:3210:
web_frame->document().getElementById("state").to<WebInputElement>();
On 2014/09/25 22:31:14, Ilya Sherman wrote:
> Hmm... how are we even able to cast to WebInputElement?  AFAICT, that's not a
> parent class for this element.

Good point! Sorry, I've been careless and didn't spot this.

https://codereview.chromium.org/605683002/diff/1/chrome/renderer/autofill/for...
chrome/renderer/autofill/form_autofill_browsertest.cc:3211:
state.setAutofilled(true);
On 2014/09/25 22:31:14, Ilya Sherman wrote:
> I'd suggest combining lines 3203 through 3211 as
> 
> // Set the value and autofilled attribute of the state element.
> WebSelectElement state =
>     web_frame->document().getElementById("state").to<WebSelectElement>();
> state.setValue(WebString::fromUTF8("AK"));
> state.setAutofilled(true);

Done.

[Ilya Sherman, 2014-09-26 19:16:22]

LGTM, thanks.

[Ilya Sherman, 2014-09-26 19:16:29]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-09-26 19:18:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605683002/20001

[commit-bot: I haz the power, 2014-09-26 20:20:20]

Committed patchset #2 (id:20001) as 45ab1372a4e683366a1bde326cc7fb13355e8b65

[commit-bot: I haz the power, 2014-09-26 20:21:11]

Patchset 2 (id:??) landed as
https://crrev.com/ca4f42145c27772afd077eda57bc36d0abc4e483
Cr-Commit-Position: refs/heads/master@{#297020}