Autofill browser_tests: set autofilled property after autofilled value is set.

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
@@ skipping 3181 matching lines @@
   form_cache.ExtractNewForms(*web_frame, &forms);
   ASSERT_EQ(1U, forms.size());
 
   // Set the auto-filled attribute.
   WebInputElement firstname =
       web_frame->document().getElementById("firstname").to<WebInputElement>();
   firstname.setAutofilled(true);
   WebInputElement lastname =
       web_frame->document().getElementById("lastname").to<WebInputElement>();
   lastname.setAutofilled(true);
-  WebInputElement state =
-      web_frame->document().getElementById("state").to<WebInputElement>();
-  state.setAutofilled(true);
 
   // Set the value of the select-one.
   WebSelectElement select_element =
       web_frame->document().getElementById("state").to<WebSelectElement>();
   select_element.setValue(WebString::fromUTF8("AK"));
 
+  // Set the auto-filled attribute of the select-one.
+  WebInputElement state =
+        web_frame->document().getElementById("state").to<WebInputElement>();

[Ilya Sherman, 2014/09/25 22:31:14]

Hmm... how are we even able to cast to WebInputElement?  AFAICT, that's not a
parent class for this element.

[ziran.sun, 2014/09/26 09:34:41]

Good point! Sorry, I've been careless and didn't spot this.

+  state.setAutofilled(true);

[Ilya Sherman, 2014/09/25 22:31:14]

I'd suggest combining lines 3203 through 3211 as

// Set the value and autofilled attribute of the state element.
WebSelectElement state =
    web_frame->document().getElementById("state").to<WebSelectElement>();
state.setValue(WebString::fromUTF8("AK"));
state.setAutofilled(true);

[ziran.sun, 2014/09/26 09:34:41]

Done.

+
   // Clear the form.
   EXPECT_TRUE(form_cache.ClearFormWithElement(firstname));
 
   // Verify that the auto-filled attribute has been turned off.
   EXPECT_FALSE(firstname.isAutofilled());
 
   // Verify the form is cleared.
   FormData form2;
   FormFieldData field2;
   EXPECT_TRUE(FindFormAndFieldForFormControlElement(firstname,
@@ skipping 460 matching lines @@
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("country");
   expected.value = ASCIIToUTF16("AL");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
 }  // namespace autofill