Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 605613003: Use of base::StringPairs appropriately in base (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in base Using base::StringPairs in base folder Becuase base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/f42513a7b8925d77c487033821b12fcce04ef554 Cr-Commit-Position: refs/heads/master@{#296647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/strings/string_split_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-09-25 03:36:36 UTC) #2
Nico
lgtm
6 years, 2 months ago (2014-09-25 03:48:05 UTC) #3
MRV
On 2014/09/25 03:48:05, Nico (hiding) wrote: > lgtm Thanks Mr.Nico for LGTM
6 years, 2 months ago (2014-09-25 03:53:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605613003/1
6 years, 2 months ago (2014-09-25 03:54:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 44d0e159f18a7652fbd036b0a9e8f1cc9e24bfe6
6 years, 2 months ago (2014-09-25 04:45:32 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 04:46:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f42513a7b8925d77c487033821b12fcce04ef554
Cr-Commit-Position: refs/heads/master@{#296647}

Powered by Google App Engine
This is Rietveld 408576698