Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: base/strings/string_split_unittest.cc

Issue 605613003: Use of base::StringPairs appropriately in base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_split.h" 5 #include "base/strings/string_split.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "testing/gmock/include/gmock/gmock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 13 matching lines...) Expand all
24 SplitString(WideToUTF16(str), c, &result16); 24 SplitString(WideToUTF16(str), c, &result16);
25 for (size_t i = 0; i < result16.size(); ++i) 25 for (size_t i = 0; i < result16.size(); ++i)
26 result->push_back(UTF16ToWide(result16[i])); 26 result->push_back(UTF16ToWide(result16[i]));
27 } 27 }
28 #endif 28 #endif
29 29
30 } // anonymous namespace 30 } // anonymous namespace
31 31
32 class SplitStringIntoKeyValuePairsTest : public testing::Test { 32 class SplitStringIntoKeyValuePairsTest : public testing::Test {
33 protected: 33 protected:
34 std::vector<std::pair<std::string, std::string> > kv_pairs; 34 base::StringPairs kv_pairs;
35 }; 35 };
36 36
37 TEST_F(SplitStringIntoKeyValuePairsTest, EmptyString) { 37 TEST_F(SplitStringIntoKeyValuePairsTest, EmptyString) {
38 EXPECT_TRUE(SplitStringIntoKeyValuePairs(std::string(), 38 EXPECT_TRUE(SplitStringIntoKeyValuePairs(std::string(),
39 ':', // Key-value delimiter 39 ':', // Key-value delimiter
40 ',', // Key-value pair delimiter 40 ',', // Key-value pair delimiter
41 &kv_pairs)); 41 &kv_pairs));
42 EXPECT_TRUE(kv_pairs.empty()); 42 EXPECT_TRUE(kv_pairs.empty());
43 } 43 }
44 44
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 SplitStringAlongWhitespace(data[i].input, &results); 317 SplitStringAlongWhitespace(data[i].input, &results);
318 ASSERT_EQ(data[i].expected_result_count, results.size()); 318 ASSERT_EQ(data[i].expected_result_count, results.size());
319 if (data[i].expected_result_count > 0) 319 if (data[i].expected_result_count > 0)
320 ASSERT_EQ(data[i].output1, results[0]); 320 ASSERT_EQ(data[i].output1, results[0]);
321 if (data[i].expected_result_count > 1) 321 if (data[i].expected_result_count > 1)
322 ASSERT_EQ(data[i].output2, results[1]); 322 ASSERT_EQ(data[i].output2, results[1]);
323 } 323 }
324 } 324 }
325 325
326 } // namespace base 326 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698