mojo/public/tools/bindings/pylib/mojom/generate/module.py - Issue 605443002: The default value for NullableString should be null (was "")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/module.py

Issue 605443002: The default value for NullableString should be null (was "") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test fields with type double Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/pylib/mojom/generate/module.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/module.py b/mojo/public/tools/bindings/pylib/mojom/generate/module.py

index cf5777932c5a272d564d92161b9b09f6dd52bc0b..06809ebef45fe80ca0b063602477d47fa9315eb2 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/module.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/module.py

@@ -334,6 +334,10 @@ def IsBoolKind(kind):

return kind.spec == BOOL.spec

+def IsFloatKind(kind):

+ return kind is not None and kind.spec == FLOAT.spec

yzshen1 2014/09/24 22:49:25 nit: All surrounding functions don't test kind is

hansmuller 2014/09/24 23:33:11 I've moved to the "is not None" test to the call s

def IsStringKind(kind):

return kind.spec == STRING.spec or kind.spec == NULLABLE_STRING.spec

« mojo/public/js/bindings/struct_unittests.js ('K') | « mojo/public/tools/bindings/generators/mojom_js_generator.py ('k') | no next file » | no next file with comments »